From: "Paweł Anikiel" <pan@semihalf.com>
To: marex@denx.de, simon.k.r.goldschmidt@gmail.com,
tien.fong.chee@intel.com, michal.simek@xilinx.com
Cc: u-boot@lists.denx.de, sjg@chromium.org, festevam@denx.de,
jagan@amarulasolutions.com, andre.przywara@arm.com,
narmstrong@baylibre.com, pbrobinson@gmail.com,
tharvey@gateworks.com, paul.liu@linaro.org,
christianshewitt@gmail.com, adrian.fiergolski@fastree3d.com,
marek.behun@nic.cz, wd@denx.de, elly.siew.chin.lim@intel.com,
mw@semihalf.com, "Paweł Anikiel" <pan@semihalf.com>
Subject: [PATCH 11/11] socfpga: arria10: Allow dcache_enable before relocation
Date: Fri, 1 Apr 2022 14:43:25 +0200 [thread overview]
Message-ID: <20220401124325.1810108-12-pan@semihalf.com> (raw)
In-Reply-To: <20220401124325.1810108-1-pan@semihalf.com>
Before relocating to SDRAM, the ECC is initialized by clearing the
whole SDRAM. In order to speed this up, dcache_enable is used (see
sdram_init_ecc_bits).
Since commit 503eea451903 ("arm: cp15: update DACR value to activate
access control"), this no longer works, because running code in OCRAM
with the XN bit set causes a page fault. Override dram_bank_mmu_setup
to disable XN in the OCRAM and setup DRAM dcache before relocation.
Signed-off-by: Paweł Anikiel <pan@semihalf.com>
---
arch/arm/mach-socfpga/misc_arria10.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm/mach-socfpga/misc_arria10.c b/arch/arm/mach-socfpga/misc_arria10.c
index 0ed2adfd84..7ce888d197 100644
--- a/arch/arm/mach-socfpga/misc_arria10.c
+++ b/arch/arm/mach-socfpga/misc_arria10.c
@@ -246,3 +246,29 @@ int qspi_flash_software_reset(void)
return 0;
}
#endif
+
+void dram_bank_mmu_setup(int bank)
+{
+ struct bd_info *bd = gd->bd;
+ u32 start, size;
+ int i;
+
+ /* If we're still in OCRAM, don't set the XN bit on it */
+ if (!(gd->flags & GD_FLG_RELOC)) {
+ set_section_dcache(
+ CONFIG_SYS_INIT_RAM_ADDR >> MMU_SECTION_SHIFT,
+ DCACHE_WRITETHROUGH);
+ }
+
+ /*
+ * The default implementation of this function allows the DRAM dcache
+ * to be enabled only after relocation. However, to speed up ECC
+ * initialization, we want to be able to enable DRAM dcache before
+ * relocation, so we don't check GD_FLG_RELOC (this assumes bd->bi_dram
+ * is set first).
+ */
+ start = bd->bi_dram[bank].start >> MMU_SECTION_SHIFT;
+ size = bd->bi_dram[bank].size >> MMU_SECTION_SHIFT;
+ for (i = start; i < start + size; i++)
+ set_section_dcache(i, DCACHE_DEFAULT_OPTION);
+}
--
2.35.1.1094.g7c7d902a7c-goog
next prev parent reply other threads:[~2022-04-01 13:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 12:43 [PATCH 00/11] Add Chameleon V3 support Paweł Anikiel
2022-04-01 12:43 ` [PATCH 01/11] arm: dts: Add Mercury+ AA1 devicetree Paweł Anikiel
2022-04-11 18:34 ` Simon Glass
2022-04-14 14:07 ` Paweł Anikiel
2022-04-01 12:43 ` [PATCH 02/11] arm: dts: Add Chameleonv3 handoff headers Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-14 13:58 ` Paweł Anikiel
2022-04-01 12:43 ` [PATCH 03/11] arm: dts: Add Chameleonv3 devicetree Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-14 15:57 ` Paweł Anikiel
2022-04-01 12:43 ` [PATCH 04/11] board: Add Chameleonv3 board dir Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` [PATCH 05/11] config: Add Chameleonv3 config Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` [PATCH 06/11] misc: atsha204a: Increase wake delay by tWHI Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` [PATCH 07/11] sysreset: socfpga: Use parent device for reading base address Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-14 13:33 ` Paweł Anikiel
2022-04-01 12:43 ` [PATCH 08/11] socfpga: arria10: Replace delays with busy waiting in cm_full_cfg Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` [PATCH 09/11] socfpga: arria10: Improve bitstream loading speed Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` [PATCH 10/11] socfpga: arria10: Wait for fifo empty after writing bitstream Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` Paweł Anikiel [this message]
2022-04-11 18:35 ` [PATCH 11/11] socfpga: arria10: Allow dcache_enable before relocation Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401124325.1810108-12-pan@semihalf.com \
--to=pan@semihalf.com \
--cc=adrian.fiergolski@fastree3d.com \
--cc=andre.przywara@arm.com \
--cc=christianshewitt@gmail.com \
--cc=elly.siew.chin.lim@intel.com \
--cc=festevam@denx.de \
--cc=jagan@amarulasolutions.com \
--cc=marek.behun@nic.cz \
--cc=marex@denx.de \
--cc=michal.simek@xilinx.com \
--cc=mw@semihalf.com \
--cc=narmstrong@baylibre.com \
--cc=paul.liu@linaro.org \
--cc=pbrobinson@gmail.com \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=tien.fong.chee@intel.com \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox