public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andrew Scull <ascull@google.com>
To: u-boot@lists.denx.de
Cc: sjg@chromium.org, seanga2@gmail.com,
	Andrew Scull <ascull@google.com>,
	 Wolfgang Wallner <wolfgang.wallner@br-automation.com>,
	Bin Meng <bmeng.cn@gmail.com>
Subject: [PATCH 2/8] acpi: Fix buffer overflow in do_acpi_dump()
Date: Sun,  3 Apr 2022 10:39:09 +0000	[thread overview]
Message-ID: <20220403103915.3338027-3-ascull@google.com> (raw)
In-Reply-To: <20220403103915.3338027-1-ascull@google.com>

When do_acpi_dump() converts the table name to upper case, pass the
actual size of the output buffer so that the null terminator doesn't get
written beyond the end of the buffer.

Signed-off-by: Andrew Scull <ascull@google.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Cc: Bin Meng <bmeng.cn@gmail.com>
---
 cmd/acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/acpi.c b/cmd/acpi.c
index c543f1e3c2..0e473b415d 100644
--- a/cmd/acpi.c
+++ b/cmd/acpi.c
@@ -178,7 +178,7 @@ static int do_acpi_dump(struct cmd_tbl *cmdtp, int flag, int argc,
 		printf("Table name '%s' must be four characters\n", name);
 		return CMD_RET_FAILURE;
 	}
-	str_to_upper(name, sig, -1);
+	str_to_upper(name, sig, ACPI_NAME_LEN);
 	ret = dump_table_name(sig);
 	if (ret) {
 		printf("Table '%.*s' not found\n", ACPI_NAME_LEN, sig);
-- 
2.35.1.1094.g7c7d902a7c-goog


  parent reply	other threads:[~2022-04-03 10:39 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 10:39 [PATCH 0/8] Fix misc ASAN reports Andrew Scull
2022-04-03 10:39 ` [PATCH 1/8] doc: Correct position of gdb '--args' parameter Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` Andrew Scull [this message]
2022-04-11 18:35   ` [PATCH 2/8] acpi: Fix buffer overflow in do_acpi_dump() Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 3/8] x86: sandbox: Add missing PCI bar to barinfo Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 4/8] usb: sandbox: Check for string end in copy_to_unicode() Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 5/8] usb: sandbox: Bounds check read from buffer Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 6/8] sound: Fix buffer overflow in square wave generation Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 7/8] test: Fix pointer overrun in dm_test_devm_regmap() Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 8/8] test: dm: devres: Remove use-after-free Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-06 18:31 ` [PATCH 0/8] Fix misc ASAN reports Sean Anderson
2022-04-07  6:41   ` Andrew Scull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220403103915.3338027-3-ascull@google.com \
    --to=ascull@google.com \
    --cc=bmeng.cn@gmail.com \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=wolfgang.wallner@br-automation.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox