[PATCH 8/8] test: dm: devres: Remove use-after-free

Andrew Scull
2022-04-03T10:41:35Z

Use-after-free shouldn't be used, even in tests. It's bad practice and
makes the test brittle.

Signed-off-by: Andrew Scull <ascull@google.com>
Cc: Simon Glass <sjg@chromium.org>
---
test/dm/devres.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/test/dm/devres.c b/test/dm/devres.c
index 4f959d11da..524114c833 100644
--- a/test/dm/devres.c
+++ b/test/dm/devres.c
@@ -178,11 +178,8 @@ static int dm_test_devres_phase(struct unit_test_state *uts)
ut_asserteq(1, stats.allocs);
ut_asserteq(TEST_DEVRES_SIZE, stats.total_size);

- /* Unbinding removes the other. Note this access a freed pointer */
+ /* Unbinding removes the other. */
device_unbind(dev);
- devres_get_stats(dev, &stats);
- ut_asserteq(0, stats.allocs);
- ut_asserteq(0, stats.total_size);

return 0;
}
--
2.35.1.1094.g7c7d902a7c-goog