public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andrew Scull <ascull@google.com>
To: u-boot@lists.denx.de
Cc: sjg@chromium.org, seanga2@gmail.com, Andrew Scull <ascull@google.com>
Subject: [PATCH 8/8] test: dm: devres: Remove use-after-free
Date: Sun,  3 Apr 2022 10:39:15 +0000	[thread overview]
Message-ID: <20220403103915.3338027-9-ascull@google.com> (raw)
In-Reply-To: <20220403103915.3338027-1-ascull@google.com>

Use-after-free shouldn't be used, even in tests. It's bad practice and
makes the test brittle.

Signed-off-by: Andrew Scull <ascull@google.com>
Cc: Simon Glass <sjg@chromium.org>
---
 test/dm/devres.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/test/dm/devres.c b/test/dm/devres.c
index 4f959d11da..524114c833 100644
--- a/test/dm/devres.c
+++ b/test/dm/devres.c
@@ -178,11 +178,8 @@ static int dm_test_devres_phase(struct unit_test_state *uts)
 	ut_asserteq(1, stats.allocs);
 	ut_asserteq(TEST_DEVRES_SIZE, stats.total_size);
 
-	/* Unbinding removes the other. Note this access a freed pointer */
+	/* Unbinding removes the other. */
 	device_unbind(dev);
-	devres_get_stats(dev, &stats);
-	ut_asserteq(0, stats.allocs);
-	ut_asserteq(0, stats.total_size);
 
 	return 0;
 }
-- 
2.35.1.1094.g7c7d902a7c-goog


  parent reply	other threads:[~2022-04-03 10:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 10:39 [PATCH 0/8] Fix misc ASAN reports Andrew Scull
2022-04-03 10:39 ` [PATCH 1/8] doc: Correct position of gdb '--args' parameter Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 2/8] acpi: Fix buffer overflow in do_acpi_dump() Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 3/8] x86: sandbox: Add missing PCI bar to barinfo Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 4/8] usb: sandbox: Check for string end in copy_to_unicode() Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 5/8] usb: sandbox: Bounds check read from buffer Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 6/8] sound: Fix buffer overflow in square wave generation Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` [PATCH 7/8] test: Fix pointer overrun in dm_test_devm_regmap() Andrew Scull
2022-04-11 18:35   ` Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-03 10:39 ` Andrew Scull [this message]
2022-04-11 18:35   ` [PATCH 8/8] test: dm: devres: Remove use-after-free Simon Glass
2022-04-29 18:03   ` Tom Rini
2022-04-06 18:31 ` [PATCH 0/8] Fix misc ASAN reports Sean Anderson
2022-04-07  6:41   ` Andrew Scull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220403103915.3338027-9-ascull@google.com \
    --to=ascull@google.com \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox