From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A895C433EF for ; Sun, 3 Apr 2022 10:41:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E9ABA83B63; Sun, 3 Apr 2022 12:40:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="IqIEu8dK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 69E3683B25; Sun, 3 Apr 2022 12:39:45 +0200 (CEST) Received: from mail-wm1-x349.google.com (mail-wm1-x349.google.com [IPv6:2a00:1450:4864:20::349]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8430D83AC9 for ; Sun, 3 Apr 2022 12:39:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=3Z3lJYgYKBpg2K4MDD8GG8D6.4GEM-3GGLDAKLK.56FP.56@flex--ascull.bounces.google.com Received: by mail-wm1-x349.google.com with SMTP id m35-20020a05600c3b2300b0038c90ef2dceso5394400wms.4 for ; Sun, 03 Apr 2022 03:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=/CUUlFSK8+QxDwDHujxP7DmXixENiRsGaAAF0ihPDWU=; b=IqIEu8dKuJgdUFI3Gxofyd32UFlB8O8eKA8ZBpJCIrqDDHCMMEDZTgskpATqjKV3hG Fy4qP8juM76L58zF+9PrJvRhjf8NL1885ysxHKNeUrgKhwSb+caRaH0WSnUSGBKgqm9F gL0jJGWk+nAsDUtouPimQ8T3UMQTT2/T/lQx0cpr0hLk8XH302ApZE2DOtK+2+WxlqAi Ssz0Cx0P40W24n+/mITPyedzu+11sUhr1cfmgDhlLDGOZkj4r8U5NIPC/TwFYbW5kwGW zudWFFB/BXf9jhTmjKDR1spkt/+3AodxYuGaf1NtgroLX/xbnFA4FjiMqKkXUPEciC4d BUDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=/CUUlFSK8+QxDwDHujxP7DmXixENiRsGaAAF0ihPDWU=; b=ziehynB0p5Odd6HuifjXw4mNGa2Qe6CXtfhMN+uFSgw51EBBe6VYI+woZpBaQKIM6a GnOqMXEEyF03q6+KK8CspJY6PTRJhdQczCV6vN78IOl+sTOTmzrih6SKlJjx2htMRhvQ xAbmQAA+ZQfsnGwwJzj764VW9mI5Q081vjp+5sLvBCwnvoBXrCHxYN3Bst9ZF3XYHPWX bDsdwnRMW2V28Lc5iOU6Sv87nl82A1mZHeJk7l2q7jqcPjCKSvTIi6AaOVAuGBcKSqzv kVvhA9uHVdnXc/jYBYUjxK/0W8Z90yo75B56vGGQal6WKMyMgs4Kvv55esVm7ABgqmR6 NHow== X-Gm-Message-State: AOAM5339WHzNlCc9AA6YNR/GN/q8E4xLogIkOklIQDEIqJlxv3GUBVF2 zTz5W/0f7s6cgd57RzqZPD69mwUlqAjGR5IV38zeexBRICohj/GmVpRpz5ociewbYtYwi5L84Os JKteb/94ZI4IooRZimDipDfcdBUzwzdX8BiDYVqIkikVGOp/2xtmx5byMhvY= X-Google-Smtp-Source: ABdhPJwBEgBuCtp6cBJ1SeyEePlLY0aFm/1OTUaq7Bc/i8fRKYTsr3dhUvQNiRaUy+64lAPfaLIyGOY9hYU= X-Received: from ascull.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:1510]) (user=ascull job=sendgmr) by 2002:a1c:4e05:0:b0:38c:a3a3:b998 with SMTP id g5-20020a1c4e05000000b0038ca3a3b998mr15734634wmh.95.1648982375048; Sun, 03 Apr 2022 03:39:35 -0700 (PDT) Date: Sun, 3 Apr 2022 10:39:15 +0000 In-Reply-To: <20220403103915.3338027-1-ascull@google.com> Message-Id: <20220403103915.3338027-9-ascull@google.com> Mime-Version: 1.0 References: <20220403103915.3338027-1-ascull@google.com> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog Subject: [PATCH 8/8] test: dm: devres: Remove use-after-free From: Andrew Scull To: u-boot@lists.denx.de Cc: sjg@chromium.org, seanga2@gmail.com, Andrew Scull Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Use-after-free shouldn't be used, even in tests. It's bad practice and makes the test brittle. Signed-off-by: Andrew Scull Cc: Simon Glass --- test/dm/devres.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/dm/devres.c b/test/dm/devres.c index 4f959d11da..524114c833 100644 --- a/test/dm/devres.c +++ b/test/dm/devres.c @@ -178,11 +178,8 @@ static int dm_test_devres_phase(struct unit_test_state *uts) ut_asserteq(1, stats.allocs); ut_asserteq(TEST_DEVRES_SIZE, stats.total_size); - /* Unbinding removes the other. Note this access a freed pointer */ + /* Unbinding removes the other. */ device_unbind(dev); - devres_get_stats(dev, &stats); - ut_asserteq(0, stats.allocs); - ut_asserteq(0, stats.total_size); return 0; } -- 2.35.1.1094.g7c7d902a7c-goog