public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>,
	Alex Nemirovsky <alex.nemirovsky@cortina-access.com>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>,
	Philippe Reynes <philippe.reynes@softathome.com>,
	Sean Anderson <seanga2@gmail.com>, Simon Glass <sjg@chromium.org>,
	Steven Lawrance <steven.lawrance@softathome.com>
Subject: [PATCH 2/6] led: bcm6328: Drop duplicate OF "label" property parsing
Date: Mon,  4 Apr 2022 01:18:03 +0200	[thread overview]
Message-ID: <20220403231807.693506-2-marex@denx.de> (raw)
In-Reply-To: <20220403231807.693506-1-marex@denx.de>

The OF "label" property parsing is now handled in LED core,
drop the duplicate implementation from this driver.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alex Nemirovsky <alex.nemirovsky@cortina-access.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Philippe Reynes <philippe.reynes@softathome.com>
Cc: Sean Anderson <seanga2@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Steven Lawrance <steven.lawrance@softathome.com>
---
 drivers/led/led_bcm6328.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/led/led_bcm6328.c b/drivers/led/led_bcm6328.c
index bf8207d638d..f59a92fb1fd 100644
--- a/drivers/led/led_bcm6328.c
+++ b/drivers/led/led_bcm6328.c
@@ -204,26 +204,14 @@ static int bcm6328_led_bind(struct udevice *parent)
 	ofnode node;
 
 	dev_for_each_subnode(node, parent) {
-		struct led_uc_plat *uc_plat;
 		struct udevice *dev;
-		const char *label;
 		int ret;
 
-		label = ofnode_read_string(node, "label");
-		if (!label) {
-			debug("%s: node %s has no label\n", __func__,
-			      ofnode_get_name(node));
-			return -EINVAL;
-		}
-
 		ret = device_bind_driver_to_node(parent, "bcm6328-led",
 						 ofnode_get_name(node),
 						 node, &dev);
 		if (ret)
 			return ret;
-
-		uc_plat = dev_get_uclass_plat(dev);
-		uc_plat->label = label;
 	}
 
 	return 0;
-- 
2.35.1


  reply	other threads:[~2022-04-03 23:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 23:18 [PATCH 1/6] led: Move OF "label" property parsing to core Marek Vasut
2022-04-03 23:18 ` Marek Vasut [this message]
2022-04-15 12:07   ` [PATCH 2/6] led: bcm6328: Drop duplicate OF "label" property parsing Tom Rini
2022-04-03 23:18 ` [PATCH 3/6] led: bcm6358: " Marek Vasut
2022-04-15 12:07   ` Tom Rini
2022-04-03 23:18 ` [PATCH 4/6] led: bcm6858: " Marek Vasut
2022-04-15 12:07   ` Tom Rini
2022-04-03 23:18 ` [PATCH 5/6] led: cortina: " Marek Vasut
2022-04-15 12:07   ` Tom Rini
2022-04-03 23:18 ` [PATCH 6/6] led: gpio: " Marek Vasut
2022-04-15 12:07   ` Tom Rini
2022-04-14 14:14 ` [PATCH 1/2] led: bcm6753: " Tom Rini
2022-04-14 14:15   ` [PATCH 2/2] led: pwm: " Tom Rini
2022-04-15 12:08     ` Tom Rini
2022-04-15 12:07   ` [PATCH 1/2] led: bcm6753: " Tom Rini
2022-04-15 12:07 ` [PATCH 1/6] led: Move OF "label" property parsing to core Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220403231807.693506-2-marex@denx.de \
    --to=marex@denx.de \
    --cc=alex.nemirovsky@cortina-access.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=philippe.reynes@softathome.com \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=steven.lawrance@softathome.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox