From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 735B1C433F5 for ; Mon, 4 Apr 2022 00:56:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D56BC83BDE; Mon, 4 Apr 2022 02:56:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id C21AF83BE4; Mon, 4 Apr 2022 02:56:31 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 2322A83BCF for ; Mon, 4 Apr 2022 02:56:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75B751FB; Sun, 3 Apr 2022 17:56:25 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6BDF73F718; Sun, 3 Apr 2022 17:56:24 -0700 (PDT) Date: Mon, 4 Apr 2022 00:32:17 +0100 From: Andre Przywara To: =?UTF-8?B?QmFsdGF6w6Fy?= Radics Cc: u-boot@lists.denx.de, Samuel Holland , Jernej =?UTF-8?B?xaBrcmFiZWM=?= , Chen-Yu Tsai , Jagan Teki Subject: Re: [PATCH v2] Add ethernet0 alias in Nanopi NEO's device tree Message-ID: <20220404003217.6161a362@slackpad.lan> In-Reply-To: <20220326120910.56376-1-baltazar.radics@gmail.com> References: <20220326120910.56376-1-baltazar.radics@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sat, 26 Mar 2022 13:09:10 +0100 Baltaz=C3=A1r Radics wrote: Hi Baltaz=C3=A1r, > This is required to enable automatic MAC address generation. For the records, this should rather be marked as a sync from the Linux tree, where this was conveniently merged just recently. In the long run we should see if we can avoid those ethernet aliases, since their only purpose seems to be to trigger U-Boot's MAC generation, and I wonder if there is a simpler way. Using U-Boot's DM interface to enumerate Ethernet devices comes to mind, for instance. This would avoid the churn of funnelling those trivial DT changes through Linux first. I will apply this and push it for the merge window, after adding the Linux tag. Thanks! Andre > Signed-off-by: Baltaz=C3=A1r Radics > --- > arch/arm/dts/sun8i-h3-nanopi-neo.dts | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/arch/arm/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/dts/sun8i-h3= -nanopi-neo.dts > index 9f33f6fae..df71fab3c 100644 > --- a/arch/arm/dts/sun8i-h3-nanopi-neo.dts > +++ b/arch/arm/dts/sun8i-h3-nanopi-neo.dts > @@ -45,6 +45,10 @@ > / { > model =3D "FriendlyARM NanoPi NEO"; > compatible =3D "friendlyarm,nanopi-neo", "allwinner,sun8i-h3"; > + > + aliases { > + ethernet0 =3D &emac; > + }; > }; > =20 > &ehci0 {