* [PATCH v2] Add ethernet0 alias in Nanopi NEO's device tree
@ 2022-03-26 12:09 Baltazár Radics
2022-04-03 23:32 ` Andre Przywara
0 siblings, 1 reply; 2+ messages in thread
From: Baltazár Radics @ 2022-03-26 12:09 UTC (permalink / raw)
To: u-boot; +Cc: Baltazár Radics
This is required to enable automatic MAC address generation.
Signed-off-by: Baltazár Radics <baltazar.radics@gmail.com>
---
arch/arm/dts/sun8i-h3-nanopi-neo.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/dts/sun8i-h3-nanopi-neo.dts
index 9f33f6fae..df71fab3c 100644
--- a/arch/arm/dts/sun8i-h3-nanopi-neo.dts
+++ b/arch/arm/dts/sun8i-h3-nanopi-neo.dts
@@ -45,6 +45,10 @@
/ {
model = "FriendlyARM NanoPi NEO";
compatible = "friendlyarm,nanopi-neo", "allwinner,sun8i-h3";
+
+ aliases {
+ ethernet0 = &emac;
+ };
};
&ehci0 {
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] Add ethernet0 alias in Nanopi NEO's device tree
2022-03-26 12:09 [PATCH v2] Add ethernet0 alias in Nanopi NEO's device tree Baltazár Radics
@ 2022-04-03 23:32 ` Andre Przywara
0 siblings, 0 replies; 2+ messages in thread
From: Andre Przywara @ 2022-04-03 23:32 UTC (permalink / raw)
To: Baltazár Radics
Cc: u-boot, Samuel Holland, Jernej Škrabec, Chen-Yu Tsai,
Jagan Teki
On Sat, 26 Mar 2022 13:09:10 +0100
Baltazár Radics <baltazar.radics@gmail.com> wrote:
Hi Baltazár,
> This is required to enable automatic MAC address generation.
For the records, this should rather be marked as a sync from the Linux
tree, where this was conveniently merged just recently.
In the long run we should see if we can avoid those ethernet aliases,
since their only purpose seems to be to trigger U-Boot's MAC
generation, and I wonder if there is a simpler way. Using U-Boot's DM
interface to enumerate Ethernet devices comes to mind, for instance.
This would avoid the churn of funnelling those trivial DT changes
through Linux first.
I will apply this and push it for the merge window, after adding the
Linux tag.
Thanks!
Andre
> Signed-off-by: Baltazár Radics <baltazar.radics@gmail.com>
> ---
> arch/arm/dts/sun8i-h3-nanopi-neo.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/dts/sun8i-h3-nanopi-neo.dts
> index 9f33f6fae..df71fab3c 100644
> --- a/arch/arm/dts/sun8i-h3-nanopi-neo.dts
> +++ b/arch/arm/dts/sun8i-h3-nanopi-neo.dts
> @@ -45,6 +45,10 @@
> / {
> model = "FriendlyARM NanoPi NEO";
> compatible = "friendlyarm,nanopi-neo", "allwinner,sun8i-h3";
> +
> + aliases {
> + ethernet0 = &emac;
> + };
> };
>
> &ehci0 {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-04 0:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-26 12:09 [PATCH v2] Add ethernet0 alias in Nanopi NEO's device tree Baltazár Radics
2022-04-03 23:32 ` Andre Przywara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox