From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77A82C433F5 for ; Mon, 4 Apr 2022 00:56:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A1A5A83B19; Mon, 4 Apr 2022 02:55:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 23B98836BF; Mon, 4 Apr 2022 02:55:52 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id B93F383BDE for ; Mon, 4 Apr 2022 02:55:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C54651FB; Sun, 3 Apr 2022 17:55:40 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 797173F718; Sun, 3 Apr 2022 17:55:39 -0700 (PDT) Date: Mon, 4 Apr 2022 01:54:48 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki , Sean Anderson , Simon Glass , Heinrich Schuchardt , Heiko Schocher , Joe Hershberger Subject: Re: [PATCH v2 00/23] sunxi: Add and use a pinctrl driver Message-ID: <20220404015448.0e5b8c32@slackpad.lan> In-Reply-To: <20220318035420.15058-1-samuel@sholland.org> References: <20220318035420.15058-1-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, 17 Mar 2022 22:53:57 -0500 Samuel Holland wrote: Hi Samuel, > This series resolves some longstanding TODOs by implementing a pinctrl > driver for sunxi platforms and converting DM drivers to use it. So as mentioned before, this is a huge step forward, and helps to remove some dodgy and heavy-maintenance code parts. Many thanks for that! So I plan on taking this into the first PR for the 2022.07 merge window, with the following changes (apart from adding my tags): - Dropping "[PATCH v2 06/23] sunxi: Skip non-DM UART pin setup when PINCTRL=y", as agreed in the review. - Dropping "[PATCH v2 15/23] sunxi: Remove non-DM I2C clock/pin setup from U-Boot", as this probably breaks older boards. IIUC, this should still work with the new functionality, the old I2C setup code would just be redundant, for now. - Fixing H5 pinmux value in "[PATCH v2 13/23] pinctrl: sunxi: Add I2C pinmuxes". - Copying a summary of the commit message from "[PATCH v2 02/23] sunxi: pinctrl: Implement pin muxing functions" into the code, as a comment. Samuel, does that make sense? If you agree, there would be no need to re-send this series. I am happy to take fixups later, for instance for some currently unknown gate clocks. I will be on holidays from Wednesday until Easter, so don't want to wait until then with that series. Thanks, Andre > > Changes in v2: > - Merge all SoC drivers into one file and one U_BOOT_DRIVER. > - Add a consumer for the APB bus clock > - Add support for the F1C100s SoC > > Samuel Holland (23): > sunxi: pinctrl: Create the driver skeleton > sunxi: pinctrl: Implement pin muxing functions > sunxi: pinctrl: Implement get_pin_muxing function > sunxi: pinctrl: Implement pin configuration > pinctrl: sunxi: Add UART pinmuxes > sunxi: Skip non-DM UART pin setup when PINCTRL=y > pinctrl: sunxi: Add sun4i EMAC pinmuxes > net: sunxi_emac: Remove non-DM pin setup > pinctrl: sunxi: Add sunxi GMAC pinmuxes > sunxi: Remove non-DM GMAC pin setup > pinctrl: sunxi: Add sun8i EMAC pinmuxes > net: sun8i_emac: Remove non-DM pin setup > pinctrl: sunxi: Add I2C pinmuxes > sunxi: Remove options and setup code for I2C2-I2C4 > sunxi: Remove non-DM I2C clock/pin setup from U-Boot > i2c: sun6i_p2wi: Only do non-DM pin setup for non-DM I2C > i2c: sun8i_rsb: Only do non-DM pin setup for non-DM I2C > pinctrl: sunxi: Add MMC pinmuxes > sunxi: Remove non-DM MMC pin setup > pinctrl: sunxi: Add the A64 PWM pinmux > pwm: sunxi: Remove non-DM pin setup > pinctrl: sunxi: Add SPI0 pinmuxes > spi: sun4i_spi: Remove non-DM pin setup > > MAINTAINERS | 1 + > arch/arm/Kconfig | 1 + > arch/arm/include/asm/arch-sunxi/gpio.h | 17 +- > arch/arm/include/asm/arch-sunxi/i2c.h | 11 +- > arch/arm/mach-sunxi/Kconfig | 22 - > arch/arm/mach-sunxi/board.c | 2 + > board/sunxi/board.c | 67 -- > board/sunxi/gmac.c | 55 -- > drivers/gpio/sunxi_gpio.c | 130 +--- > drivers/i2c/sun6i_p2wi.c | 12 +- > drivers/i2c/sun8i_rsb.c | 46 +- > drivers/net/sun8i_emac.c | 90 --- > drivers/net/sunxi_emac.c | 7 +- > drivers/pinctrl/Kconfig | 1 + > drivers/pinctrl/Makefile | 2 +- > drivers/pinctrl/sunxi/Kconfig | 127 ++++ > drivers/pinctrl/sunxi/Makefile | 3 + > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 887 +++++++++++++++++++++++++ > drivers/pwm/sunxi_pwm.c | 11 - > drivers/spi/spi-sunxi.c | 84 --- > 20 files changed, 1057 insertions(+), 519 deletions(-) > create mode 100644 drivers/pinctrl/sunxi/Kconfig > create mode 100644 drivers/pinctrl/sunxi/Makefile > create mode 100644 drivers/pinctrl/sunxi/pinctrl-sunxi.c >