Re: [PATCH v2 07/23] pinctrl: sunxi: Add sun4i EMAC pinmuxes

Andre Przywara
2022-03-31T23:28:21Z

On Thu, 17 Mar 2022 22:54:04 -0500
Samuel Holland <samuel@sholland.org> wrote:

> Pin lists and mux values were taken from the Linux drivers.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Compared against the respective manuals.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>
> (no changes since v1)
>
> drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> index 751b47d687..2525a91e35 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> @@ -240,6 +240,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused suniv_f1c100s_pinctrl_desc
> };
>
> static const struct sunxi_pinctrl_function sun4i_a10_pinctrl_functions[] = {
> + { "emac", 2 }, /* PA0-PA17 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> @@ -257,6 +258,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun4i_a10_pinctrl_desc = {
> };
>
> static const struct sunxi_pinctrl_function sun5i_a13_pinctrl_functions[] = {
> + { "emac", 2 }, /* PA0-PA17 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> @@ -305,6 +307,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun6i_a31_r_pinctrl_desc =
> };
>
> static const struct sunxi_pinctrl_function sun7i_a20_pinctrl_functions[] = {
> + { "emac", 2 }, /* PA0-PA17 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)