Re: [PATCH v2 11/23] pinctrl: sunxi: Add sun8i EMAC pinmuxes

Andre Przywara
2022-03-31T23:33:16Z

On Thu, 17 Mar 2022 22:54:08 -0500
Samuel Holland <samuel@sholland.org> wrote:

> Pin lists and mux values were taken from the Linux drivers.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Compared against the respective manuals.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>
> (no changes since v1)
>
> drivers/pinctrl/sunxi/pinctrl-sunxi.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> index 7540e7668a..2de793689a 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> @@ -376,6 +376,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun8i_a33_pinctrl_desc = {
> };
>
> static const struct sunxi_pinctrl_function sun8i_a83t_pinctrl_functions[] = {
> + { "gmac", 4 }, /* PD2-PD23 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> @@ -408,6 +409,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun8i_a83t_r_pinctrl_desc
> };
>
> static const struct sunxi_pinctrl_function sun8i_h3_pinctrl_functions[] = {
> + { "emac", 2 }, /* PD0-PD17 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> @@ -440,6 +442,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun8i_h3_r_pinctrl_desc =
> };
>
> static const struct sunxi_pinctrl_function sun8i_v3s_pinctrl_functions[] = {
> + { "emac", 4 }, /* PD0-PD17 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> @@ -490,6 +493,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun9i_a80_r_pinctrl_desc =
> };
>
> static const struct sunxi_pinctrl_function sun50i_a64_pinctrl_functions[] = {
> + { "emac", 4 }, /* PD8-PD23 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> @@ -522,6 +526,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun50i_a64_r_pinctrl_desc
> };
>
> static const struct sunxi_pinctrl_function sun50i_h5_pinctrl_functions[] = {
> + { "emac", 2 }, /* PD0-PD17 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> @@ -541,6 +546,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun50i_h5_pinctrl_desc = {
> };
>
> static const struct sunxi_pinctrl_function sun50i_h6_pinctrl_functions[] = {
> + { "emac", 5 }, /* PD0-PD20 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> @@ -572,6 +578,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun50i_h6_r_pinctrl_desc =
> };
>
> static const struct sunxi_pinctrl_function sun50i_h616_pinctrl_functions[] = {
> + { "emac0", 2 }, /* PI0-PI16 */
> { "gpio_in", 0 },
> { "gpio_out", 1 },
> #if IS_ENABLED(CONFIG_UART0_PORT_F)