From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3985BC433F5 for ; Mon, 4 Apr 2022 07:57:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BEBD082A31; Mon, 4 Apr 2022 09:57:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="A1g3t28y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E848781DDF; Mon, 4 Apr 2022 09:57:49 +0200 (CEST) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6FCA839E3 for ; Mon, 4 Apr 2022 09:57:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPS id 4D2A71407C7; Mon, 4 Apr 2022 09:57:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1649059058; bh=Zh7cbDOuyBTfqSoJKZiXgikGdvHtYyrp6lj8wmDFWV8=; h=Date:From:To; b=A1g3t28ywZgfr9J7DzNQ2eHFFM8ejBwOk93Vscpsexzg+b4Pm5QFWdmMC5NQJhjrl /Q2fdvKzmTczmYJF2+OwjL06nmcX8IXE2FWMbCHPhYPsdP7+IS1jmkHP+H9vYhtG+j jDvy9nzKIDNKabNJDrnsnlMEvscy8qdAynIOf9AY= Date: Mon, 4 Apr 2022 09:57:36 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Adrian Fiergolski , Wolfgang Denk , Simon Glass , Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH] misc: atsha204a: Fix big endian support Message-ID: <20220404095736.0c7342d3@thinkpad> In-Reply-To: <20220402223634.20256-1-pali@kernel.org> References: <20220402223634.20256-1-pali@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sun, 3 Apr 2022 00:36:34 +0200 Pali Roh=C3=A1r wrote: > Callers of function atsha204a_crc16() expect to return value in host cpu > endianity. So remove cpu_to_le16() conversion. >=20 > Signed-off-by: Pali Roh=C3=A1r > --- > drivers/misc/atsha204a-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c > index b89463babb56..63fe541dade3 100644 > --- a/drivers/misc/atsha204a-i2c.c > +++ b/drivers/misc/atsha204a-i2c.c > @@ -146,7 +146,7 @@ static u16 atsha204a_crc16(const u8 *buffer, size_t l= en) > while (len--) > crc =3D crc16_byte(crc, *buffer++); > =20 > - return cpu_to_le16(crc); > + return crc; > } > =20 > static int atsha204a_send(struct udevice *dev, const u8 *buf, u8 len) Reviewed-by: Marek Beh=C3=BAn