Re: [PATCH 7/8] powerpc: mpc85xx: Set TEXT_BASE addresses to real base values

Pali Rohár
2022-05-11T19:43:31Z

On Monday 25 April 2022 14:31:16 Pali Rohár wrote:
> On Monday 25 April 2022 04:27:51 Priyanka Jain (OSS) wrote:
> > >-----Original Message-----
> > >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Pali Rohár
> > >Sent: Tuesday, April 5, 2022 6:43 PM
> > >To: Priyanka Jain <priyanka.jain@nxp.com>; Qiang Zhao <qiang.zhao@nxp.com>;
> > >Shengzhou Liu <shengzhou.liu@nxp.com>; Alexander Graf <agraf@csgraf.de>;
> > >Bin Meng <bmeng.cn@gmail.com>; Wolfgang Denk <wd@denx.de>; Sinan
> > >Akman <sinan@writeme.com>
> > >Cc: u-boot@lists.denx.de
> > >Subject: [PATCH 7/8] powerpc: mpc85xx: Set TEXT_BASE addresses to real base
> > >values
> > >
> > >Currently CONFIG_SPL_TEXT_BASE and CONFIG_SYS_TEXT_BASE addresses are
> > >manually increased by 0x1000 due to .bootpg section. This section has size of
> > >0x1000 bytes and is manually put by linker script before .text section (and
> > >therefore before base address) when CONFIG_SYS_MPC85XX_NO_RESETVEC is
> > >set. Due to this fact lot of other config options are manually increased by
> > >0x1000 value to make correct layout. Note that entry point is not on
> > >CONFIG_SPL_TEXT_BASE (image+0x1000) but it is really on address
> > >CONFIG_SPL_TEXT_BASE-0x1000 (means at the start of the image).
> > >
> > >Cleanup handling of .bootpg section when
> > >CONFIG_SYS_MPC85XX_NO_RESETVEC is set. Put .bootpg code directly into .text
> > >section and move text base address to the start of .bootpg code. And finally
> > >remove +0x1000 value from lot of config options. With this removal custom
> > >PHDRS is not used anymore, so remove it too.
> > >
> > >After this change entry point would be at CONFIG_SPL_TEXT_BASE and not at
> > >address -0x1000 anymore.
> > >
> > >Tested on P2020 board with SPL and proper U-Boot.
> > >
> > >Signed-off-by: Pali Rohár <pali@kernel.org>
> > >---
> >
> > Kindly rebase to top of tree. There has been changed related configs.
> > I am picking patches till 6/8. So just send next version of 7/8 and 8/8
>
> Done! I rebased 7/8 on top of master and sent V2 to ML. 8/8 in current
> version still cleanly applied on 7/8, so I did not resent it. If there
> is some issue, please let me know.

PING?