From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43E38C433F5 for ; Tue, 5 Apr 2022 13:28:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6269483927; Tue, 5 Apr 2022 15:28:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="FUNLid6y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7F8BC83927; Tue, 5 Apr 2022 15:28:53 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D7B6683ADC for ; Tue, 5 Apr 2022 15:28:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 840FF6186A; Tue, 5 Apr 2022 13:28:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7AC2C385A2; Tue, 5 Apr 2022 13:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649165326; bh=u8zirco/VwpN3RtmqpYnnM5nAKxDsnf3VLdn0hwgRmE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FUNLid6y0zk3Efhe0C7TJHsRtSBaVT8MvpbYiM9kW9LDMjSqMwIlLjqv4X/ymvV5B Y9uOASHGBLTGmm5pXdYaA/Eu4h9BjCsrfL0UzX0nyswScPDpR63RBxsHvgp3CG4hJt 1JcXsvqvA4s0nf5i3BAqcdwgI+M1zIhn1pL6TpCcs5AvG6TZWq0sIo5ZqtF1SV1HT+ RtmwvppM2XrXkZv9YhxoCKcqiDgaenSSFh6hrJDUabyU5TE4SFN6KeaSlCOZQFZ0S6 S/iH8GzKmGkYae/tF2SH0kbdMtHL2CsuXIN10RvOYOcQKDQtR31tgVDJuVMINTTmgH UX/xGc3M3OZDQ== Received: by pali.im (Postfix) id 2DF477B2; Tue, 5 Apr 2022 15:28:43 +0200 (CEST) Date: Tue, 5 Apr 2022 15:28:43 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Stefan Roese Cc: Adrian Fiergolski , Marek =?utf-8?B?QmVow7pu?= , Wolfgang Denk , Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH] misc: atsha204a: Add support for atsha204 chip Message-ID: <20220405132843.kccajblmkek2jdph@pali> References: <20220405124908.32019-1-pali@kernel.org> <8865d906-d91d-2938-1f31-645854265874@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8865d906-d91d-2938-1f31-645854265874@denx.de> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Tuesday 05 April 2022 15:14:52 Stefan Roese wrote: > On 4/5/22 14:49, Pali Rohár wrote: > > atsha204 chip is predecessor of atsha204a chip. Current U-Boot driver > > atsha204a-i2c.c can use both atsha204 and atsha204a chips because it does > > not call specific functions to just one of these chips. > > > > So just add compatible string for atsha204. > > > > Signed-off-by: Pali Rohár > > --- > > drivers/misc/atsha204a-i2c.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c > > index 63fe541dade3..8b0055f99893 100644 > > --- a/drivers/misc/atsha204a-i2c.c > > +++ b/drivers/misc/atsha204a-i2c.c > > @@ -399,6 +399,7 @@ static int atsha204a_of_to_plat(struct udevice *dev) > > } > > static const struct udevice_id atsha204a_ids[] = { > > + { .compatible = "atmel,atsha204" }, > > { .compatible = "atmel,atsha204a" }, > > { } > > }; > > Why do we need this new compatible here in the driver? They are different chips, so should have different compatible strings. > A quick grep > doesn't show this in any of the dts files, not in U-Boot and not in the > Kernel. Not yet. I'm preparing patches for a board which has atsha204 and will use this u-boot driver. > Just checking... > > Thanks, > Stefan