From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2872CC433F5 for ; Tue, 5 Apr 2022 23:02:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6762583B8A; Wed, 6 Apr 2022 01:02:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2783783B0E; Wed, 6 Apr 2022 01:02:36 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id A62AC83B58 for ; Wed, 6 Apr 2022 01:02:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 10E7F1424; Tue, 5 Apr 2022 16:02:30 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5E3423F718; Tue, 5 Apr 2022 16:02:29 -0700 (PDT) Date: Tue, 5 Apr 2022 23:57:06 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki Subject: Re: [PATCH v5 0/3] sunxi: TOC0 image type support Message-ID: <20220405235706.4671aeb1@slackpad.lan> In-Reply-To: <20220318050046.63624-1-samuel@sholland.org> References: <20220318050046.63624-1-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Fri, 18 Mar 2022 00:00:42 -0500 Samuel Holland wrote: > This series adds support for the TOC0 image format used by the Allwinner > secure boot ROM (SBROM). This series has been tested on the following > SoCs/boards, with the eFuse burnt to enable secure mode: > - A50: Ainol Q88 Tablet > - A64: Pine A64 Plus > - H5: Orange Pi Zero Plus > - H6: Pine H64 Model B > - H616: Orange Pi Zero 2 > > This time I also tested it on boards that are not switched to secure > mode (with A64, H3, and H5). > > Due to both series changing Makefile.spl, the last patch depends on: > https://patchwork.ozlabs.org/project/uboot/list/?series=267136 > I have seen no comments on that series, so I assume that it is ready to > merge along with this one. Fixed up the 32-bit build issue in patch 2/3, then merged into sunxi/master (together with Icenowy's RISC-V series). All landed in mainline now. Thanks! Andre > > Changes in v5: > - Rebased on top of suniv platform additions > - Took care of additional hardcoded offset in SPL SPI code > - Dropped controversial Kconfig patch > > Changes in v4: > - Do not select TOOLS_LIBCRYPTO anywhere > > Changes in v3: > - Removed TOOLS_LIBCRYPTO selection for sunxi, since most boards > do not need it > - Added __packed to all new "ABI" structs > - Added entry to MAINTAINERS for sunxi tools > - Fixed offset of magic passed to memcmp > - Refactored functions to not return pointers (fixes ambiguous NULL) > > Changes in v2: > - Moved certificate and key item structures out of sunxi_image.h > - Renamed "main" and "item" variables for clarity > - Improved error messages, and added a hint about key generation > - Added a comment explaining the purpose of the various key files > - Mentioned testing this code on A50 in the commit message > - Moved SPL header signature checks out of sunxi_image.h > - Refactored SPL header signature checks to use fewer casts > - Rebase on top of Icenowy's RISC-V support series > - Rename Kconfig symbols to include the full image type name > > Samuel Holland (3): > tools: mkimage: Add Allwinner TOC0 support > sunxi: Support SPL in both eGON and TOC0 images > sunxi: Support building a SPL as a TOC0 image > > MAINTAINERS | 1 + > arch/arm/include/asm/arch-sunxi/spl.h | 3 +- > arch/arm/mach-sunxi/Kconfig | 2 + > arch/arm/mach-sunxi/board.c | 39 +- > arch/arm/mach-sunxi/spl_spi_sunxi.c | 2 +- > board/sunxi/Kconfig | 24 + > boot/image.c | 1 + > include/image.h | 1 + > include/sunxi_image.h | 37 ++ > scripts/Makefile.spl | 5 +- > tools/Makefile | 7 +- > tools/sunxi_toc0.c | 907 ++++++++++++++++++++++++++ > 12 files changed, 1013 insertions(+), 16 deletions(-) > create mode 100644 board/sunxi/Kconfig > create mode 100644 tools/sunxi_toc0.c >