From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69EBBC433EF for ; Wed, 6 Apr 2022 13:48:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3BCEB83D31; Wed, 6 Apr 2022 15:48:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="XNelHpkJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A0B5E83D2A; Wed, 6 Apr 2022 15:48:22 +0200 (CEST) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D3D7C83DBA for ; Wed, 6 Apr 2022 15:48:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf30.google.com with SMTP id kk12so2216190qvb.13 for ; Wed, 06 Apr 2022 06:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yzM16WRoFIaMD651CVd92JLbpYmjuoucyq84i+zQumY=; b=XNelHpkJMXtV6JLeIXRf7xtGxFB/aj49zwoTf3V7tYtfm4awdg0aAT8CfgM3E/lKcq CuB598PnvbIOxklIcDUw95qXy5kaVISK4v8nF7jjgDO5AdF+i9jHWN1z4BqgzqkL/5kv W/1ew2j4xhCGFASfif43tZ1Lz/toZ5gzODJbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yzM16WRoFIaMD651CVd92JLbpYmjuoucyq84i+zQumY=; b=FN/2FlktHnjarEYLiVi1dquPHIGgcawvwYUNbDJLW6oAZgnK9U/ccSUQrwMD6lj+I5 Cm9VI8oHFL8wTf3kX49HXJCYDQrrKxkZC/JiCgkncuf9ch/VvwFqjKOLQ5Bu+E0NFC+5 J2xi8C6TNf4MYpFW10lMlQqxnYRNFNegfFj2/ohIqOkarccHVW22+StaL3q7hc8fE9NF enasVqr9RAFKxt+tNtrCSYFQsg9xRypMYzRWpAajrIhvDtzRaWxfFINfadUsoXVoigML gw1XV2/XEw1RP9cWK1H7A0dkVrqfOaXsKMIPctlAWH99xS5K0UH16aetBcn6MoEQoZtN ft7g== X-Gm-Message-State: AOAM5325o6svvL2uZUuvqNOYRlXYhZ6PEEII+hPgJppK6U6fZFXWDFj3 255tQPktiesk30Ada8N/u1Z2aA== X-Google-Smtp-Source: ABdhPJwS12AzrFzUYTnVmm74uFYgkE7U9/i1q9PVwTU1JGozIpLwAVcpxfdgvyBkTTA6dLZAmlCF3A== X-Received: by 2002:a05:6214:b6a:b0:443:d340:c194 with SMTP id ey10-20020a0562140b6a00b00443d340c194mr7257195qvb.112.1649252891443; Wed, 06 Apr 2022 06:48:11 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id o3-20020a05622a008300b002e06a103476sm13576593qtw.55.2022.04.06.06.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:48:10 -0700 (PDT) Date: Wed, 6 Apr 2022 09:48:08 -0400 From: Tom Rini To: Jim Liu Cc: JJLIU0@nuvoton.com, YSCHU@nuvoton.com, KWLIU@nuvoton.com, lukma@denx.de, seanga2@gmail.com, sjg@chromium.org, sr@denx.de, u-boot@lists.denx.de Subject: Re: [PATCH v1 6/6] arm: nuvoton: Add support for Nuvoton NPCM750 BMC Message-ID: <20220406134808.GD14282@bill-the-cat> References: <20220406075737.27938-1-JJLIU0@nuvoton.com> <20220406075737.27938-7-JJLIU0@nuvoton.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AkbCVLjbJ9qUtAXD" Content-Disposition: inline In-Reply-To: <20220406075737.27938-7-JJLIU0@nuvoton.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --AkbCVLjbJ9qUtAXD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 06, 2022 at 03:57:37PM +0800, Jim Liu wrote: > Add basic support for the Nuvoton NPCM750 BMC >=20 > Signed-off-by: Jim Liu [snip] > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 4567c183fb..45ab2793b2 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -922,6 +922,12 @@ config ARCH_NEXELL > select DM > select GPIO_EXTRA_HEADER > =20 > +config ARCH_NPCM > + bool "Support Nuvoton SoCs" > + select DM > + select OF_CONTROL > + imply CMD_DM I see this in a lot of your Kconfig changes, the spacing is wrong/inconsistent, please fix to be a single tab of indentation. > diff --git a/arch/arm/mach-nuvoton/npcm7xx/reset.c b/arch/arm/mach-nuvoto= n/npcm7xx/reset.c > new file mode 100644 > index 0000000000..74f925f67b > --- /dev/null > +++ b/arch/arm/mach-nuvoton/npcm7xx/reset.c I feel this should be doing something under/with drivers/reset/ instead. > +int board_init(void) > +{ > + gd->bd->bi_arch_number =3D CONFIG_MACH_TYPE; > + gd->bd->bi_boot_params =3D (PHYS_SDRAM_1 + 0x100UL); Do you really need to support non-DT kernels? CONFIG_MACH_TYPE should likely not be used here. > diff --git a/include/configs/poleg.h b/include/configs/poleg.h > new file mode 100644 > index 0000000000..549b198285 > --- /dev/null > +++ b/include/configs/poleg.h > @@ -0,0 +1,77 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Copyright (c) 2021 Nuvoton Technology Corp. > + */ > + > +#ifndef __CONFIG_POLEG_H > +#define __CONFIG_POLEG_H > + > +#undef CONFIG_USE_IRQ Ugh, I see that line made it back in, in another board. That's not meaningful. > +#define CONFIG_ARCH_CPU_INIT > +#define CONFIG_ENV_OVERWRITE > + > +#define CONFIG_MACH_TYPE MACH_TYPE_NPCMX50 > + > +#define CONFIG_SETUP_MEMORY_TAGS > +#define CONFIG_INITRD_TAG TAGS are part of Kconfig, if you _really_ need them still. Please make use of CI: https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html to make sure the series passes there as we have tests to catch things which need to be in Kconfig not board.h files such as this and some others that follow. > +#define CONFIG_SYS_BAUDRATE_TABLE {115200, 57600, 38400} Please just use the default baudrate table. > diff --git a/include/dt-bindings/reset/nuvoton,npcm7xx-reset.h b/include/= dt-bindings/reset/nuvoton,npcm7xx-reset.h > new file mode 100644 > index 0000000000..2831918804 > --- /dev/null > +++ b/include/dt-bindings/reset/nuvoton,npcm7xx-reset.h Is this coming in unmodified from Linux? Thanks! --=20 Tom --AkbCVLjbJ9qUtAXD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJNmhgACgkQFHw5/5Y0 tyyocgv+MKPieLkm/Wy0U/YFCnKiGabSmAe5vvQz/RoAwDdg9bZ2+REssXA6EdAV zFqAI+wgK+XjVxe2gUgq/8cw9bnQE5Y902p2mwCoOi2ZdUKJWN4A1E992DNLY1LG zmvNUkHbhKdCklv5cQQ1HoUBJ8c7ONCg3kv14ICl07cWfhZWckZpPZb/EnxEns3O Nj6f4zqDK6NDR160Xp6X+rTB/7mMwNfWpFjcNZGiIrBaisAupxaILactR/GEcXV/ B1krQlvqZvxpPL98kiaj6sXWav+Ml/4g/bluS/vQ/chAmNZyztKwlx4rDlJRn4ZQ XRTgwE/kcCoj8X7Hij5a/bU4wOCVC9U2SlOOwJWzuF6yzt6owIqCIXRNFPe6dsSL q9lw8UhAmXPwaSYLWidr89BeaLmvvIlndJVgMhZso7ge79EgiWVssvoDzIMVCb2c HlyIQHKFJVqsMeoSk3BRD7tfMdb4fJKN4qKsDenueZx5/5X1i1BXyJLEkJGcjjp1 hgSYJiXF =fEKf -----END PGP SIGNATURE----- --AkbCVLjbJ9qUtAXD--