From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1906C433F5 for ; Wed, 6 Apr 2022 19:23:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B3BF08269E; Wed, 6 Apr 2022 21:22:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="Ohfqf98a"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5504980818; Wed, 6 Apr 2022 21:22:56 +0200 (CEST) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DE0CE8269E for ; Wed, 6 Apr 2022 21:22:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPS id 7CF2313F917; Wed, 6 Apr 2022 21:22:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1649272972; bh=h60ka+s+EDvyYso3wSqlK5him04bkdgutY3EbDyot18=; h=Date:From:To:Cc:Subject:From; b=Ohfqf98a13Zvq5SmuO1V11jlFuGUV9iYpA8wAuWYjLh0EMOXG9ANxMCUBUzrUIlfe MPfqG1X0Ri5B1Q+rhXGJ989qfjX32ZD1v9fQurMRzvavO/D3lXjP+MEvIwqzEmF2tW pSxUve12SRPbU+/TH1dD5KVsREb/rFuuTYh+utlw= Date: Wed, 6 Apr 2022 21:22:51 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH] tools: kwboot: Replace fstat()+st_size by lseek()+SEEK_END Message-ID: <20220406212251.4a54b9c4@thinkpad> In-Reply-To: <20220406131859.7693-1-pali@kernel.org> References: <20220406131859.7693-1-pali@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, 6 Apr 2022 15:18:59 +0200 Pali Roh=C3=A1r wrote: > fstat()'s st_size works only for regular files. lseek() with SEEK_END wor= ks > also for block or MTD devices. This replacement allows kwboot to load > kwbimage from /dev/mtd0 for booting another device over /dev/ttyS0. >=20 > Signed-off-by: Pali Roh=C3=A1r Nice. Reviewed-by: Marek Beh=C3=BAn