Re: [PATCH 2/5] arm: mvebu: turris_omnia: Define CONFIG_ETHPRIME instead of ethact= ENV

Stefan Roese
2022-05-02T15:42:06Z

On 06.04.22 11:39, Pali Rohár wrote:
> CONFIG_ETHPRIME defines primary ethernet device and env variable $ethact
> stores currently active ethernet device.
>
> So there is no point to set ethact= in default environment. Instead set
> CONFIG_ETHPRIME properly.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> include/configs/turris_omnia.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/configs/turris_omnia.h b/include/configs/turris_omnia.h
> index b35299b2fbb3..15f874ea22e1 100644
> --- a/include/configs/turris_omnia.h
> +++ b/include/configs/turris_omnia.h
> @@ -26,6 +26,8 @@
> "fdt_high=0x10000000\0" \
> "initrd_high=0x10000000\0"
>
> +#define CONFIG_ETHPRIME "ethernet@34000"
> +
> /* Defines for SPL */
> #define CONFIG_SPL_SIZE (140 << 10)
> #define CONFIG_SPL_MAX_SIZE (CONFIG_SPL_SIZE - (CONFIG_SPL_TEXT_BASE - 0x40000000))
> @@ -119,7 +121,6 @@
> LOAD_ADDRESS_ENV_SETTINGS \
> "fdtfile=" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0" \
> "console=ttyS0,115200\0" \
> - "ethact=ethernet@34000\0" \
> "bootcmd_rescue=" TURRIS_OMNIA_BOOTCMD_RESCUE "\0" \
> BOOTENV
>

Applied to u-boot-marvell/master

Thanks,
Stefan