From: "Marek Behún" <kabel@kernel.org>
To: Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>
Cc: u-boot@lists.denx.de, "Marek Behún" <marek.behun@nic.cz>
Subject: [PATCH u-boot-net v4 13/14] bcmgenet, sun8i_emac: Don't connect PHY two times
Date: Thu, 7 Apr 2022 00:33:07 +0200 [thread overview]
Message-ID: <20220406223308.9833-14-kabel@kernel.org> (raw)
In-Reply-To: <20220406223308.9833-1-kabel@kernel.org>
From: Marek Behún <marek.behun@nic.cz>
The bcmgenet and sun8i_emac drivers call phy_connect(), which finds /
creates the PHY and also connects it to the eth device via
phy_connect_dev(), then set some phydev members (bcmgenet only), and
then call phy_connect_dev() explicitly again.
Drop the second phy_connect_dev(), since it is unnecesary.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
---
drivers/net/bcmgenet.c | 2 --
drivers/net/sun8i_emac.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/net/bcmgenet.c b/drivers/net/bcmgenet.c
index ef321f2839..4e1f8ed7a4 100644
--- a/drivers/net/bcmgenet.c
+++ b/drivers/net/bcmgenet.c
@@ -526,8 +526,6 @@ static int bcmgenet_phy_init(struct bcmgenet_eth_priv *priv, void *dev)
}
phydev->advertising = phydev->supported;
- phy_connect_dev(phydev, dev);
-
priv->phydev = phydev;
phy_config(priv->phydev);
diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
index 5943a5e3f0..906a8ec5d0 100644
--- a/drivers/net/sun8i_emac.c
+++ b/drivers/net/sun8i_emac.c
@@ -391,8 +391,6 @@ static int sun8i_phy_init(struct emac_eth_dev *priv, void *dev)
if (!phydev)
return -ENODEV;
- phy_connect_dev(phydev, dev);
-
priv->phydev = phydev;
phy_config(priv->phydev);
--
2.35.1
next prev parent reply other threads:[~2022-04-06 22:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 22:32 [PATCH u-boot-net v4 00/14] u-boot-net refactors, fixes, cleanups Marek Behún
2022-04-06 22:32 ` [PATCH u-boot-net v4 01/14] net: mdio-uclass: fix type for phy_mode_str and phy_handle_str Marek Behún
2022-04-06 22:32 ` [PATCH u-boot-net v4 02/14] net: mdio-uclass: use ARRAY_SIZE() Marek Behún
2022-04-06 22:32 ` [PATCH u-boot-net v4 03/14] net: introduce helpers to get PHY ofnode from MAC Marek Behún
2022-04-13 21:46 ` Tom Rini
2022-04-14 15:39 ` Tom Rini
2022-04-06 22:32 ` [PATCH u-boot-net v4 04/14] net: mdio-uclass: add wrappers for read/write/reset operations Marek Behún
2022-04-06 22:32 ` [PATCH u-boot-net v4 05/14] treewide: use dm_mdio_read/write/reset() wrappers Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 06/14] net: phy: fix parsing wrong property Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 07/14] net: introduce helpers to get PHY interface mode from a device/ofnode Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 08/14] treewide: Rename PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 09/14] treewide: Rename PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NA Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 10/14] phy: Move PHY_INTERFACE_MODE_NA to the beginning of the enum definition Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 11/14] net: phy: xilinx: Check interface type in ->config(), not ->probe() Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 12/14] net: phy: use ->is_c45 instead of is_10g_interface() Marek Behún
2022-04-06 22:33 ` Marek Behún [this message]
2022-04-06 22:33 ` [PATCH u-boot-net v4 14/14] net: phy: don't require PHY interface mode during PHY creation Marek Behún
2022-04-10 5:02 ` [PATCH u-boot-net v4 00/14] u-boot-net refactors, fixes, cleanups Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406223308.9833-14-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=joe.hershberger@ni.com \
--cc=marek.behun@nic.cz \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox