Re: [PATCH v2 00/52] mips: octeon: Add ethernet support

Stefan Roese
2022-05-02T16:00:21Z

Hi Daniel,

On 07.04.22 09:11, Stefan Roese wrote:
> This patchset adds the networking files and drivers including device
> helper headers and C files. Please excuse the massive amount of files
> in this patch series. Also the sometimes huge files (mostly headers
> with register definitions) that I needed to include.
>
> The infrastructure code with all the headers is ported mistly without
> any intended functional changes from the 2013 Cavium / Marvell U-Boot
> version. It has undergone many hours of extensive code cleanup and
> reformatting. Some of it done by using tools (checkpatch, Lindent, clang
> format etc) and also some of it done manually, as I couldn't find some
> tools that could do the needed work in a reliable and functional way.
> The result is that checkpatch now only throws a "few" warnings that are
> left. Some of those can't be removed without an even more extensive
> cleanup / rewrite of the code, like the addition of typedefs.
>
> The added header, helper and infrastructure files in the first part of
> the patch-series (patches 1-43) are the foundation, that is used by the
> main Octeon U-Boot ethernet driver (patch 50/52). Patches 47-49 add the
> DT nodes and properties to the corresponding dtsi / dts files. Patches
> 51 & 52 finally enable the ethernet support both MIPS Octeon boards,
> EBB7304 & NIC23.
>
> All this is tested on the 2 Cavium / Marvell MIPS Octeon boards:
> EBB7304 & NIC23
>
> This patchset including the small Marvell PHY patches is available in
> this gitlab branch:
>
> https://source.denx.de/u-boot/custodians/u-boot-marvell/-/tree/mips-octeon-ethernet-v2-2022-04-07
>
> Changes in v2:
> - As suggested by Daniel, remove all unreferenced functions from the source
> code by manually inspecting u-boot.map [1]
> - Rebased on latest TOT
>
> [1] Here the diffstat comarison between v1 and v2:
> v1: 77 files changed, 42315 insertions(+), 586 deletions(-)
> v2: 78 files changed, 33672 insertions(+), 2524 deletions(-)
>
> Thanks,
> Stefan

Daniel, do you have any comments on this patchset? Tom has assigned it
to me in patchwork and I would really like to get it merged into
mainline, if possible. So if you don't have any obejctions, then I
would pull it via the Marvell tree soon.

Thanks,
Stefan