From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06E69C433FE for ; Thu, 7 Apr 2022 08:29:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 22A21833EC; Thu, 7 Apr 2022 10:29:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="urxxoAm1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E613C83B42; Thu, 7 Apr 2022 10:29:34 +0200 (CEST) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3F1CD80FF0 for ; Thu, 7 Apr 2022 10:29:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 76215CE26BB; Thu, 7 Apr 2022 08:29:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8AE2C385A4; Thu, 7 Apr 2022 08:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649320167; bh=cSclCQ9BZDm+8NL3uKZQM3wk7Qv6OQiwMqCh8t7qTYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=urxxoAm16ePC5/b+N2eCLoR3nH9vCQ0NvNk9FvIf5k6gGWd463ghuSpMdmBC1wDVG gYeU9Iwyx+ruZCrEEiDKOG/dY9f4dambzBCLdRBz0xSh3cShmLWI79+8pjXB88DC1u m8WbkEVByRUJh3shBoXxqZ7UqmjiB6RuIHGK8zuurLMa2+DqoQKGXbRIDRwD7pfdhr WePx4xZRKjId7Ccuzn9DyP5QidoICes0+j0zq/6RaxeZWBWXeR+nlVXgr5IbmvvE4q G75JDzne2t3VBW8NDl5aq8thBD7ANaUQQjZ9GYaWYhTBQPv+9RKrS5YkMBZToO/Hx8 MQj1AH5QoP1HA== Received: by pali.im (Postfix) id EA9297E4; Thu, 7 Apr 2022 10:29:23 +0200 (CEST) Date: Thu, 7 Apr 2022 10:29:23 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Stefan Roese Cc: Adrian Fiergolski , Marek =?utf-8?B?QmVow7pu?= , Wolfgang Denk , Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH] misc: atsha204a: Fix big endian support Message-ID: <20220407082923.vxflakcprch3e5k2@pali> References: <20220402223634.20256-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Monday 04 April 2022 09:43:21 Stefan Roese wrote: > On 4/3/22 00:36, Pali Rohár wrote: > > Callers of function atsha204a_crc16() expect to return value in host cpu > > endianity. So remove cpu_to_le16() conversion. > > > > Signed-off-by: Pali Rohár > > Reviewed-by: Stefan Roese Hello Stefan! Would you or somebody else take this patch? Because I have some other u-boot generic patches which touches this driver and I'm waiting until this simple change would be merged first. > Thanks, > Stefan > > > --- > > drivers/misc/atsha204a-i2c.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c > > index b89463babb56..63fe541dade3 100644 > > --- a/drivers/misc/atsha204a-i2c.c > > +++ b/drivers/misc/atsha204a-i2c.c > > @@ -146,7 +146,7 @@ static u16 atsha204a_crc16(const u8 *buffer, size_t len) > > while (len--) > > crc = crc16_byte(crc, *buffer++); > > - return cpu_to_le16(crc); > > + return crc; > > } > > static int atsha204a_send(struct udevice *dev, const u8 *buf, u8 len) > > Viele Grüße, > Stefan Roese > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de