From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Joao Marcos Costa <joaomarcos.costa@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH] squashfs: Fix compilation on big endian systems
Date: Thu, 7 Apr 2022 09:54:21 +0200 [thread overview]
Message-ID: <20220407095421.7a3a2508@xps13> (raw)
In-Reply-To: <20220406213153.30437-1-pali@kernel.org>
Hi Pali,
pali@kernel.org wrote on Wed, 6 Apr 2022 23:31:53 +0200:
Would you mind explaining a little bit how this change fixes it? It
does not look straightforward to me.
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> fs/squashfs/sqfs.c | 3 +--
> fs/squashfs/sqfs_dir.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c
> index 5d9c52af80ba..41cb811c1b32 100644
> --- a/fs/squashfs/sqfs.c
> +++ b/fs/squashfs/sqfs.c
> @@ -11,8 +11,7 @@
> #include <errno.h>
> #include <fs.h>
> #include <linux/types.h>
> -#include <linux/byteorder/little_endian.h>
> -#include <linux/byteorder/generic.h>
> +#include <asm/byteorder.h>
> #include <memalign.h>
> #include <stdlib.h>
> #include <string.h>
> diff --git a/fs/squashfs/sqfs_dir.c b/fs/squashfs/sqfs_dir.c
> index a265b98fe685..ed83c90682ff 100644
> --- a/fs/squashfs/sqfs_dir.c
> +++ b/fs/squashfs/sqfs_dir.c
> @@ -7,8 +7,7 @@
>
> #include <errno.h>
> #include <linux/types.h>
> -#include <linux/byteorder/little_endian.h>
> -#include <linux/byteorder/generic.h>
> +#include <asm/byteorder.h>
> #include <stdint.h>
> #include <stdio.h>
> #include <stdlib.h>
Cheers,
Miquèl
next prev parent reply other threads:[~2022-04-07 7:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 21:31 [PATCH] squashfs: Fix compilation on big endian systems Pali Rohár
2022-04-07 7:54 ` Miquel Raynal [this message]
2022-04-07 9:41 ` Pali Rohár
2022-04-07 9:54 ` Miquel Raynal
2022-04-07 9:58 ` Pali Rohár
2022-06-01 14:08 ` Tom Rini
2022-06-03 14:24 ` Miquel Raynal
2022-05-10 14:33 ` Pali Rohár
2022-05-23 9:32 ` Pali Rohár
2022-06-03 19:48 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407095421.7a3a2508@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=joaomarcos.costa@bootlin.com \
--cc=pali@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox