From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <u-boot-bounces@lists.denx.de>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from phobos.denx.de (phobos.denx.de [85.214.62.61])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id 496EDC433EF
	for <u-boot@archiver.kernel.org>; Thu,  7 Apr 2022 07:54:31 +0000 (UTC)
Received: from h2850616.stratoserver.net (localhost [IPv6:::1])
	by phobos.denx.de (Postfix) with ESMTP id 0A24983B58;
	Thu,  7 Apr 2022 09:54:29 +0200 (CEST)
Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com
Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de
Authentication-Results: phobos.denx.de;
	dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="UlbykysM";
	dkim-atps=neutral
Received: by phobos.denx.de (Postfix, from userid 109)
 id 567B78309E; Thu,  7 Apr 2022 09:54:26 +0200 (CEST)
Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net
 [IPv6:2001:4b98:dc4:8::226])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by phobos.denx.de (Postfix) with ESMTPS id 6FAB6833EC
 for <u-boot@lists.denx.de>; Thu,  7 Apr 2022 09:54:23 +0200 (CEST)
Authentication-Results: phobos.denx.de;
 dmarc=pass (p=reject dis=none) header.from=bootlin.com
Authentication-Results: phobos.denx.de;
 spf=pass smtp.mailfrom=miquel.raynal@bootlin.com
Received: (Authenticated sender: miquel.raynal@bootlin.com)
 by mail.gandi.net (Postfix) with ESMTPSA id 49CACC0006;
 Thu,  7 Apr 2022 07:54:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1;
 t=1649318062;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=pjH8FAUf+RI4Tr3Fxt434trsaJnLivMCMSHRFY9HGUA=;
 b=UlbykysM+2Kk/cv3Q1o1Dbu6cAyHHvHegPj5jawtOIPi+Vk8QOnRGnKv7bz/233hUlKFa9
 M76WJF+Q7DhdX/jPUQyXZ2joEqBYRcwk2o2z3NBNnJW7v8gQxlkZwxImvuJlNnSpojwrqQ
 Vo2091vIe68Y6N1SnTBbcHjPAx5iWFxV8WdN0A6BroKI0ehdrV+BB1XnoOsBaKY3uO1xCk
 xab0iDHzx4ZF/DGn0Vzyo3jXvohP/iUL6TKV3VJTidjmzEwHiDsFOPPBmoJ1/cctJoOYaO
 PJH4iK1xrtx0/lg3MBMiKO8QMC0Kdz1lItRTUFULOVuyAbflhi2bAcmZYaiFeQ==
Date: Thu, 7 Apr 2022 09:54:21 +0200
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pali =?UTF-8?B?Um9ow6Fy?= <pali@kernel.org>
Cc: Joao Marcos Costa <joaomarcos.costa@bootlin.com>, Thomas Petazzoni
 <thomas.petazzoni@bootlin.com>, u-boot@lists.denx.de
Subject: Re: [PATCH] squashfs: Fix compilation on big endian systems
Message-ID: <20220407095421.7a3a2508@xps13>
In-Reply-To: <20220406213153.30437-1-pali@kernel.org>
References: <20220406213153.30437-1-pali@kernel.org>
Organization: Bootlin
X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: u-boot@lists.denx.de
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: U-Boot discussion <u-boot.lists.denx.de>
List-Unsubscribe: <https://lists.denx.de/options/u-boot>,
 <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>
List-Archive: <https://lists.denx.de/pipermail/u-boot/>
List-Post: <mailto:u-boot@lists.denx.de>
List-Help: <mailto:u-boot-request@lists.denx.de?subject=help>
List-Subscribe: <https://lists.denx.de/listinfo/u-boot>,
 <mailto:u-boot-request@lists.denx.de?subject=subscribe>
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de
X-Virus-Status: Clean

Hi Pali,

pali@kernel.org wrote on Wed,  6 Apr 2022 23:31:53 +0200:

Would you mind explaining a little bit how this change fixes it? It
does not look straightforward to me.

> Signed-off-by: Pali Roh=C3=A1r <pali@kernel.org>
> ---
>  fs/squashfs/sqfs.c     | 3 +--
>  fs/squashfs/sqfs_dir.c | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c
> index 5d9c52af80ba..41cb811c1b32 100644
> --- a/fs/squashfs/sqfs.c
> +++ b/fs/squashfs/sqfs.c
> @@ -11,8 +11,7 @@
>  #include <errno.h>
>  #include <fs.h>
>  #include <linux/types.h>
> -#include <linux/byteorder/little_endian.h>
> -#include <linux/byteorder/generic.h>
> +#include <asm/byteorder.h>
>  #include <memalign.h>
>  #include <stdlib.h>
>  #include <string.h>
> diff --git a/fs/squashfs/sqfs_dir.c b/fs/squashfs/sqfs_dir.c
> index a265b98fe685..ed83c90682ff 100644
> --- a/fs/squashfs/sqfs_dir.c
> +++ b/fs/squashfs/sqfs_dir.c
> @@ -7,8 +7,7 @@
> =20
>  #include <errno.h>
>  #include <linux/types.h>
> -#include <linux/byteorder/little_endian.h>
> -#include <linux/byteorder/generic.h>
> +#include <asm/byteorder.h>
>  #include <stdint.h>
>  #include <stdio.h>
>  #include <stdlib.h>

Cheers,
Miqu=C3=A8l