From: "Marek Behún" <marek.behun@nic.cz>
To: "Pali Rohár" <pali@kernel.org>
Cc: Qu Wenruo <wqu@suse.com>, u-boot@lists.denx.de
Subject: Re: [PATCH] btrfs: Fix compilation on big endian systems
Date: Thu, 7 Apr 2022 14:56:16 +0200 [thread overview]
Message-ID: <20220407145616.0e9affca@thinkpad> (raw)
In-Reply-To: <20220407125103.5074-1-pali@kernel.org>
On Thu, 7 Apr 2022 14:51:03 +0200
Pali Rohár <pali@kernel.org> wrote:
> Fix following two compile errors on big endian systems:
>
> CC fs/btrfs/btrfs.o
> In file included from include/linux/byteorder/big_endian.h:107,
> from ./arch/powerpc/include/asm/byteorder.h:82,
> from ./arch/powerpc/include/asm/bitops.h:8,
> from include/linux/bitops.h:152,
> from include/uuid.h:9,
> from fs/btrfs/btrfs.c:10:
> fs/btrfs/conv-funcs.h: In function ‘btrfs_key_to_disk’:
> include/linux/byteorder/generic.h:90:21: error: ‘__cpu_to_le16’ undeclared (first use in this function); did you mean ‘__cpu_to_le16p’?
> #define cpu_to_le16 __cpu_to_le16
> ^~~~~~~~~~~~~
> fs/btrfs/conv-funcs.h:79:10: note: in expansion of macro ‘cpu_to_le16’
> __u16: cpu_to_le16, \
> ^~~~~~~~~~~
>
> CC fs/btrfs/compression.o
> In file included from ./arch/powerpc/include/asm/unaligned.h:9,
> from fs/btrfs/compression.c:16:
> include/linux/unaligned/access_ok.h:6:19: error: redefinition of ‘get_unaligned_le16’
> static inline u16 get_unaligned_le16(const void *p)
> ^~~~~~~~~~~~~~~~~~
> In file included from fs/btrfs/ctree.h:16,
> from fs/btrfs/btrfs.h:12,
> from fs/btrfs/compression.c:8:
> include/linux/unaligned/le_byteshift.h:40:19: note: previous definition of ‘get_unaligned_le16’ was here
> static inline u16 get_unaligned_le16(const void *p)
> ^~~~~~~~~~~~~~~~~~
>
> Include file asm/unaligned.h contains arch specific macros and functions
> for unaligned access as opposite to linux/unaligned le_byteshift.h which
> contains macros and functions specific to little endian systems only.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
next prev parent reply other threads:[~2022-04-07 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 12:51 [PATCH] btrfs: Fix compilation on big endian systems Pali Rohár
2022-04-07 12:56 ` Marek Behún [this message]
2022-04-07 22:41 ` Qu Wenruo
2022-04-20 13:11 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407145616.0e9affca@thinkpad \
--to=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=u-boot@lists.denx.de \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox