From: Tom Rini <trini@konsulko.com>
To: Felix.Vietmeyer@jila.colorado.edu
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] env: Load env when ENV_IS_NOWHERE is only location selected
Date: Fri, 8 Apr 2022 08:30:55 -0400 [thread overview]
Message-ID: <20220408123055.GY14282@bill-the-cat> (raw)
In-Reply-To: <02f1e164b5d59237dd8cd221c9f7f96a.squirrel@jilau1.colorado.edu>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Tue, Apr 20, 2021 at 08:04:26PM -0600, Felix.Vietmeyer@jila.colorado.edu wrote:
> This patch prevent u-boot from hanging on a UltraZed EG board (zynqmp).
>
> Without the patch,
> (drv = env_driver_lookup(ENVOP_INIT, prio))
> evaluates to 0, causing prio = 0
> Then, (!prio) is hit, returning -ENODEV causing a stall.
>
> With the patch,
> instead of returning -ENODEV and causing a stall, we
> set gd->env_addr (is this really needed?)
> and then
> mark gd->env_valid = ENV_INVALID to use the default env.
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-04-08 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 2:04 [PATCH] env: Load env when ENV_IS_NOWHERE is only location selected Felix.Vietmeyer at jila.colorado.edu
2022-04-08 12:30 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408123055.GY14282@bill-the-cat \
--to=trini@konsulko.com \
--cc=Felix.Vietmeyer@jila.colorado.edu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox