From: "Pali Rohár" <pali@kernel.org>
To: Stefan Roese <sr@denx.de>, Marek Behun <marek.behun@nic.cz>
Cc: u-boot@lists.denx.de
Subject: [PATCH 2/4] board: turris: Do not cache Atsha device in BSS
Date: Fri, 8 Apr 2022 16:30:13 +0200 [thread overview]
Message-ID: <20220408143015.23163-2-pali@kernel.org> (raw)
In-Reply-To: <20220408143015.23163-1-pali@kernel.org>
Atsha device is used prior relocation and at this early stage BSS does not
have to be ready yet. So do not cache Atsha device in BSS.
Fixes support for other Turris routers.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
board/CZ.NIC/turris_atsha_otp.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/board/CZ.NIC/turris_atsha_otp.c b/board/CZ.NIC/turris_atsha_otp.c
index a4a77c74fb19..840721a9b737 100644
--- a/board/CZ.NIC/turris_atsha_otp.c
+++ b/board/CZ.NIC/turris_atsha_otp.c
@@ -18,10 +18,8 @@
static struct udevice *get_atsha204a_dev(void)
{
- static struct udevice *dev;
-
- if (dev)
- return dev;
+ /* Cannot be static because BSS does not have to be ready at this early stage */
+ struct udevice *dev;
if (uclass_get_device_by_name(UCLASS_MISC, "atsha204a@64", &dev)) {
puts("Cannot find ATSHA204A on I2C bus!\n");
--
2.20.1
next prev parent reply other threads:[~2022-04-08 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 14:30 [PATCH 1/4] board: turris: Move Turris Atsha OTP code to separate file Pali Rohár
2022-04-08 14:30 ` Pali Rohár [this message]
2022-04-08 17:45 ` [PATCH 2/4] board: turris: Do not cache Atsha device in BSS Marek Behún
2022-04-21 14:14 ` Stefan Roese
2022-04-08 14:30 ` [PATCH 3/4] board: turris: Allow to specify first eth idx of first MAC address Pali Rohár
2022-04-08 17:45 ` Marek Behún
2022-04-21 14:15 ` Stefan Roese
2022-04-08 14:30 ` [PATCH 4/4] board: turris: Rename atsha204a@64 DT node to crypto@64 Pali Rohár
2022-04-08 17:46 ` Marek Behún
2022-04-21 14:15 ` Stefan Roese
2022-04-08 17:45 ` [PATCH 1/4] board: turris: Move Turris Atsha OTP code to separate file Marek Behún
2022-04-21 14:14 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408143015.23163-2-pali@kernel.org \
--to=pali@kernel.org \
--cc=marek.behun@nic.cz \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox