From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 970C9C433F5 for ; Fri, 8 Apr 2022 14:47:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E0B7C8390C; Fri, 8 Apr 2022 16:47:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Af13EbxK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 00D3983919; Fri, 8 Apr 2022 16:47:41 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3BAF980330 for ; Fri, 8 Apr 2022 16:47:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id t207so3563642qke.2 for ; Fri, 08 Apr 2022 07:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bm3I7l2EMaPa8lisIyoYWcN+9B4XQkPIoPHbjwBJIQo=; b=Af13EbxKZ1Q6Rzxl13AtN4uPzn9oAptCC2TbTAi1XAp7fdNr6z5WFvuDMarbuzsGo1 iDh6Wtxjqy+3E+HVEVKLkDwvQOq1/vX9RU0OOp+mXWi84mkOG9FaTquRT6qU9kcbqqw0 7TjECHsblwLjMPqkEGwog7JVcgFvNrLE+8rsc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bm3I7l2EMaPa8lisIyoYWcN+9B4XQkPIoPHbjwBJIQo=; b=xKD0JpsKuXY6EX/EFuZ3DoRf2x2+CYS/Vuhf/ymIfo8isi9hhA25nrdlzFTOm5iGwD AmkajiHpzRyfkyUM40zgq8ztLwGN9Xvr8PtN7uKrZfIeKT7TpwsuZiCeDMcmjt0FUYP6 trf5JeDmWHBKEPYK0OMHwwuO6x0BJV4bAKLxtvpwfzGHHuuFDIvAMP9ImrDo84jJcvp4 CsIPoXfAEfmOVaNJmSi5x7DuSEdrMEiF/CP/jcMJ7QyrNuJOhhuNDe8MTs59V2tTHuCv JZ3wFW7LARAmpS8LFGCi3TzEaRBYMih1FnSlSttdYJqgznEM0jUMXHByYy1S/aYOPKLF nDpQ== X-Gm-Message-State: AOAM530f7TAuhEfu95dU+WoHe3JL84OFqZUmCWKfZ4WVXY+YJ3wNpM45 rF+dzPChtYNoSvtr2LSwBEbIfum9T4ebpQ== X-Google-Smtp-Source: ABdhPJxawiUQzXEGAiVfL+uUhJ8PZ/X8cNSaY1JI0+sDdeNYiWdZAbBd0+65bZ+rgCRVSSUhk6ihEQ== X-Received: by 2002:a37:b141:0:b0:69b:ea55:b20e with SMTP id a62-20020a37b141000000b0069bea55b20emr1144061qkf.316.1649429256721; Fri, 08 Apr 2022 07:47:36 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id s132-20020a37a98a000000b0069bd92c7dcbsm1384350qke.16.2022.04.08.07.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 07:47:35 -0700 (PDT) Date: Fri, 8 Apr 2022 10:47:33 -0400 From: Tom Rini To: u-boot@lists.denx.de Cc: Pratyush Yadav , Jagan Teki Subject: Re: [v2 13/25] spi: cadence_qspi: Migrate CONFIG_CQSPI_REF_CLK to Kconfig Message-ID: <20220408144733.GC14282@bill-the-cat> References: <20220330220735.908616-13-trini@konsulko.com> <20220331193526.909109-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nQHD+3g9yI+EYXJy" Content-Disposition: inline In-Reply-To: <20220331193526.909109-1-trini@konsulko.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --nQHD+3g9yI+EYXJy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 31, 2022 at 03:35:26PM -0400, Tom Rini wrote: > This is a little tricky since SoCFPGA has code to determine this as > runtime. Introduce a guard variable for platforms to select if they > have a static value to use. Then for ARCH_SOCFPGA, call > cm_get_qspi_controller_clk_hz() and otherwise continue the previous > behavior. >=20 > Cc: Jagan Teki > Signed-off-by: Tom Rini OK, so there's a problem with using IS_ENABLED(..) which is that we get a failure to build in the not-enabled case over CONFIG_CQSPI_REF_CLK being unset. And then we can't use if (CONFIG_VAL(..)) because we then run in to needing it to exist for SPL as well. I'm going to go back to v1 of this particular patch. --=20 Tom --nQHD+3g9yI+EYXJy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJQSvsACgkQFHw5/5Y0 tywVMAwAoSqy0RW7ssmGe1zyVUI1JT0ko16i7SRX8MmyyG3erMuu7xRqaebR2C7K n7FwrmL3G+DlkFcMbSsEkizo0LrMZT7/tToKaCKA9nUAioCljAB1CCqm9wkvW+2p ZpoUpPzu0ca75UVCgxQXal6RtqQX3K4+ovDCHZjNWapYLmuSDiF9ysy35MvM2kHo ynMJKX5m9rVmp0iLqSGrupNsrsLvGCPDC2VuXA1WEqtPHnVdyIeKcAVzv1NTFSZC itBvVWO0ol3iy7jbfGK/kHlWfjVP5Uymo8x7io0lShKlG6LebSa8dGlV68DRNtDJ 0tAP51R0OQIlb6BEQck6c9PROI9d2d3aq2mL10oMMatkendNhb+Up9+CQhH4SJAR ZGRaNSlbKccq1XH3jVlP/Doz44joiWmG+dVk6uadHdplz5hqsXMe15jCVB+ZOpLQ nldjEXmchuBm1Eij9rSJc7HLQSEueCMH2GqxUcS4J9pFZxK2Rx30Rkwgx3w98aQQ daOKaqpd =YN7i -----END PGP SIGNATURE----- --nQHD+3g9yI+EYXJy--