From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27FC9C433F5 for ; Sun, 10 Apr 2022 15:21:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4B86383DB8; Sun, 10 Apr 2022 17:21:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="uhz9EiFL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 03FF483DC8; Sun, 10 Apr 2022 17:21:14 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E252183DC4 for ; Sun, 10 Apr 2022 17:21:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id s6so375qta.1 for ; Sun, 10 Apr 2022 08:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cJG/4nnRW4PXF1luZVvVLBjNsWPNYR0V1VgI/5XEPcE=; b=uhz9EiFLtkEfL0N4lljmRMRpGlVbHfrplkoPo0nNpi/WFG7pEd7CvWn5KNHeoeTJ5i J9DGI7IbhJlwiKGn/FLoY8TmPyUSKS4vhPsqScjhS3OfNKnNjOdEFUdz7uMYQZQlTMEl ABLfd+yq2SOdR4d0wL0YAA+wyKOKIJRUUVZLg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cJG/4nnRW4PXF1luZVvVLBjNsWPNYR0V1VgI/5XEPcE=; b=etiaWxwshuokNk6UYoNL58JOh+zRlWi3Uj1Wm7evXAGbcFzMrydDj0y10EOSHjqruj T4WqjCgdTvx7nznmzVW52T5udxFb9AC8ife7JlUzNd4LVrm+Mwo4i61WDRzpSh0SxNE5 dJYAfl3IpfRghBrwMOeUrzd5l4FOpv+A5owEs+hZ1RHDHE3yu2RrJT1E71TBXalMhEXO xhiCHBRzqxlsN2aDZBXbVS3/kaXxtwTnNZH6rm2G/5fu2oQATpQxXlVIZeFPQksjZygK rsZufg+56ujTfTX258pw28I3rn5zvT0I0JoOhCYmOAN3h7H46MaKccmIvLChn5ZxNYxD 9u7Q== X-Gm-Message-State: AOAM533D1wCKPaSu6K1iIHnsDwBvsKCE5YHZWz7VpqOhOKHAdpral+yv SeiBTP8t7gEeV9jD2rXwUY+TaneMx7XWgw== X-Google-Smtp-Source: ABdhPJzX8devK9fbdnUxKJYZM5WZeYeTYCNsaR0z/c0YwP64C8pSpkkAHnsx4mCGcRYYwRsd15ZJkQ== X-Received: by 2002:a05:622a:15d6:b0:2eb:9b15:b3be with SMTP id d22-20020a05622a15d600b002eb9b15b3bemr22980352qty.449.1649604059698; Sun, 10 Apr 2022 08:20:59 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id r4-20020a05620a03c400b0069c108f74aasm1410014qkm.15.2022.04.10.08.20.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Apr 2022 08:20:59 -0700 (PDT) Date: Sun, 10 Apr 2022 11:20:57 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, "Felix . Vietmeyer @ jila . colorado . edu" Subject: Re: [PATCH] Revert "env: Load env when ENV_IS_NOWHERE is only location selected" Message-ID: <20220410152057.GS14282@bill-the-cat> References: <20220410044652.714323-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KGa77y161pGt+fQU" Content-Disposition: inline In-Reply-To: <20220410044652.714323-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --KGa77y161pGt+fQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 10, 2022 at 06:46:52AM +0200, Marek Vasut wrote: > This reverts commit 8d61237edbf6314a701cf78da2c5893a73ff5438. >=20 > This commit broke environment on literally every board I have access > to, with this revert in place, environment works as it should again. > The problem I observe with this patch is that saved environment in > either SPI NOR or eMMC is never used, the system always falls back > to default environment. The 'saveenv' command does succeed, but then > after reset, the default env is again used. >=20 > Furthermore, the commit introduced duplicate code in env_init(), this: > " > if (!prio) { > gd->env_addr =3D (ulong)&default_environment[0]; > gd->env_valid =3D ENV_INVALID; >=20 > return 0; > } >=20 > if (ret =3D=3D -ENOENT) { > gd->env_addr =3D (ulong)&default_environment[0]; > gd->env_valid =3D ENV_INVALID; >=20 > return 0; > } > " >=20 > Furthermore, the commit is missing DCO SoB line. >=20 > Also note that upstream does not support UltraZed EG board, so > this might have been a patch pulled from downstream which did > depend on some other downstream behavior. >=20 > Signed-off-by: Marek Vasut > Cc: Felix.Vietmeyer@jila.colorado.edu > Cc: Tom Rini Applied to u-boot/master, thanks! --=20 Tom --KGa77y161pGt+fQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJS9dkACgkQFHw5/5Y0 tyz45Av+NKMD26FuCbmnnc4UV5Z54rFD3U9feNGEvcmBQm7fClTYXt6ejB6YaIso nhi8E2YnyqRBMLWoNBPB5QoUmelMqR+y3h2OulwVeZ33C9pdTKUu67kkSznY1+q7 eeww3KpWQWohy/XsL4mP32xWfKJKGRcK5ZpExM1+vPc2wB3SnTyyrttPS7jkXouK dARq/KOZqs5ICGzxUn8bMgBzwOhFlXOKv7eiP+A04N2HDbtmisw2qIg2V0Ni/bMo J+hGdOU0pNgfxs69qTg5uUqSeg9s62VD2ZgDIkRrlC8M2MYeOyD1qty/pUEUoAMj YVRnsPmHqrv761IoVZ00+tMWIn4DB/S6fz6ASwG1XNR77dSz2sz5vxa/LeyohSU8 o4+O27BTyENoA7zPA1U7Zuk7TZqm0/B4DfPsggtu6qgwRZgYHal/a0/VMWabuGBQ H+j5x3MhI5eJSZ+CDc4vPuSb6cAdlaSnYiF3MsRrdPtBh/3fa90Bs7mlCTe61+0L Iyli4A9r =WtlK -----END PGP SIGNATURE----- --KGa77y161pGt+fQU--