From: Tom Rini <trini@konsulko.com>
To: Nicolas Boulenguez <nicolas@debian.org>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] build: allow a downstream suffix in the version shown during boot
Date: Mon, 11 Apr 2022 11:31:28 -0400 [thread overview]
Message-ID: <20220411153128.GA1167777@bill-the-cat> (raw)
In-Reply-To: <Yi3KpUW5Hg55ezTq@pegase>
[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]
On Sun, Mar 13, 2022 at 11:42:45AM +0100, Nicolas Boulenguez wrote:
> Hello.
>
> https://lists.denx.de/pipermail/u-boot/2022-February/474887.html got
> no answer, probably because it is trivial and has been lost among more
> important topics, so I am submitting it again.
>
> It is convenient for redistributors to add a build number to the
> U-boot source version, which is displayed at boot and useful to know
> if a device has been successfully updated, to triage bugs and so on.
>
> For example, Debian adds '+dfsg-N' where N changes with each release
> of a .deb package.
>
> Author: Vagrant Cascadian <vagrant@debian.org>
> Author: Nicolas Boulenguez <nicolas@debian.org>
> Signed-By: Nicolas Boulenguez <nicolas@debian.org>
>
> --- a/Makefile
> +++ b/Makefile
> @@ -456,7 +456,7 @@ KBUILD_AFLAGS += $(call cc-option,-fno-PIE)
>
> # Read UBOOTRELEASE from include/config/uboot.release (if it exists)
> UBOOTRELEASE = $(shell cat include/config/uboot.release 2> /dev/null)
> -UBOOTVERSION = $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SUBLEVEL),.$(SUBLEVEL)))$(EXTRAVERSION)
> +UBOOTVERSION = $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SUBLEVEL),.$(SUBLEVEL)))$(EXTRAVERSION)$(BUILD_VERSION)
>
> export VERSION PATCHLEVEL SUBLEVEL UBOOTRELEASE UBOOTVERSION
> export ARCH CPU BOARD VENDOR SOC CPUDIR BOARDDIR
> --- a/doc/build/gcc.rst
> +++ b/doc/build/gcc.rst
> @@ -151,6 +151,11 @@
> Note that the :doc:`tools` are always built with the included version of libfdt
> so it is not possible to build U-Boot tools with a system libfdt, at present.
>
> +If you are modifying the upstream sources, please make this visible
> +at boot time by defining the BUILD_VERSION version suffix.
> +
> +* BUILD_VERSION=+<vendor><build number><...>
> +
> Other build targets
> ~~~~~~~~~~~~~~~~~~~
Why do you need this, instead of just using CONFIG_LOCALVERSION? What
do you do for linux kernel builds, which are also Kbuild based? Thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-04-11 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 10:42 [PATCH] build: allow a downstream suffix in the version shown during boot Nicolas Boulenguez
2022-04-11 15:31 ` Tom Rini [this message]
2022-04-13 11:59 ` Nicolas Boulenguez
-- strict thread matches above, loose matches on Subject: below --
2022-02-10 10:54 Nicolas Boulenguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411153128.GA1167777@bill-the-cat \
--to=trini@konsulko.com \
--cc=nicolas@debian.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox