From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFDDBC433F5 for ; Tue, 12 Apr 2022 01:59:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8FFE883D45; Tue, 12 Apr 2022 03:59:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="khfB+fKr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CF33583DAC; Tue, 12 Apr 2022 03:59:16 +0200 (CEST) Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 952A583ABE for ; Tue, 12 Apr 2022 03:59:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x62f.google.com with SMTP id d15so15435950pll.10 for ; Mon, 11 Apr 2022 18:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=4HRrfukgCTlIzw8dJr+P9+VQ9+AmAwqD8P2n0r3Rdgg=; b=khfB+fKrJCBDnvSQHjJwExJoT2s+umE8q4D/1Vpn4GFoB44GKS4GP8I/as4tiOZElf 3A3r8S4RRoMWCesOSuPdcdyKBYe5N9V/EomjOTzeksec6pont0jRZHdpkSGzvHPTnQQE vpHvssO1vojpkn8rU1KQVXx9pjNLlhVd39Ah+og4UBoFcSjix+22rIavD66OX2e06I1F PwWWthkXaUM6O+I1GjEmXR6jN+NIPTsK58Mj5cT0C4dXJ2EqN81aZaDpVE/0yw3EyIaG R6eQalH8v7YSZXPGPhIsONffeHdGPTdBOP39kbuKJJ6DG2Z12/WHv1VKcLZRW6hqOVqO nT8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=4HRrfukgCTlIzw8dJr+P9+VQ9+AmAwqD8P2n0r3Rdgg=; b=IRzyJJk7Ka5INhbDty3VNSPVXiN3QWLjdB1jGv0ilA5es0WrlGtmovlZy4HvojrHf4 MopGrJJI9RHVVAYjwcEOCTQTI/Q0QgAYPW4a6HGwOA8XdB8dJzyEzS5UaaQ5NBnqePKF odJRV+7B9+EJZQo0y83sQOmjdCajj+gWZ44+oudHc1A66diRve2D5jLhnaE/bobSTTbp 6uAo5JEn9cfUeWNo+zN7IEgIikpwU9ppG1dA9OphAVuFacZw/ntnrHTEWsyly77U+Rbb vDJdWthJabtMPehIfiFahJ6p0Uy5pEIZRsZDnzdww8xOjZ6/J4VIU+UpwSvEvhyn/6bT 3Okw== X-Gm-Message-State: AOAM530DKKo0+CQHTczrNKJhKPQIRK3vKOOJF3VWToSdNiXBO03HqmTz xXLtsvScY5M0MJElzMC0o05Zxg== X-Google-Smtp-Source: ABdhPJz/3y5ET/ppJiXB7lvACsVSqt6YN/QoCc8al7UpD0+U0KwbGNpA33RG/96PNpOFnnbRQD89UA== X-Received: by 2002:a17:902:d641:b0:158:7b09:a597 with SMTP id y1-20020a170902d64100b001587b09a597mr1138096plh.38.1649728751795; Mon, 11 Apr 2022 18:59:11 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:2879:8038:da7a:814]) by smtp.gmail.com with ESMTPSA id z11-20020aa7888b000000b00505bc0b970csm5837729pfe.181.2022.04.11.18.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 18:59:11 -0700 (PDT) Date: Tue, 12 Apr 2022 10:59:07 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, Kyle Evans Subject: Re: [PATCH] doc: update bootefi man-page Message-ID: <20220412015907.GA42748@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , u-boot@lists.denx.de, Kyle Evans References: <20220411191047.24078-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220411191047.24078-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, Apr 11, 2022 at 09:10:47PM +0200, Heinrich Schuchardt wrote: > A image_size parameter has been added to the bootefi parameter. > Describe all parameters. > > Correct how the description of how the device-path in the loaded > image protocol is determined. > > Signed-off-by: Heinrich Schuchardt > --- > doc/usage/cmd/bootefi.rst | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/doc/usage/cmd/bootefi.rst b/doc/usage/cmd/bootefi.rst > index 31279fc0cb..bb354b2255 100644 > --- a/doc/usage/cmd/bootefi.rst > +++ b/doc/usage/cmd/bootefi.rst > @@ -9,7 +9,7 @@ Synopsis > > :: > > - bootefi [image_addr] [fdt_addr] > + bootefi [image_addr] [fdt_addr [image_size]] I think that the syntax like bootefi [image_addr[:image_size]] [fdt_addr] would be more aligned with other commands, say booti/bootz and it would look much easier to understand and less confusing. # I remember I've got a similar comment when I posted a patch for nvedit_efi.c. -Takahiro Akashi > bootefi bootmgr [fdt_addr] > bootefi hello [fdt_addr] > bootefi selftest [fdt_addr] > @@ -41,13 +41,26 @@ command sequence to run a UEFI application might look like > load mmc 0:1 $kernel_addr_r /EFI/grub/grubaa64.efi > bootefi $kernel_addr_r $fdt_addr_r > > -The last file loaded defines the image file path in the loaded image protocol. > -Hence the executable should always be loaded last. > +The last UEFI binary loaded defines the image file path in the loaded image > +protocol. > > The value of the environment variable *bootargs* is converted from UTF-8 to > UTF-16 and passed as load options in the loaded image protocol to the UEFI > binary. > > +image_addr > + Address of the UEFI binary. > + > +fdt_addr > + Address of the device-tree or '-'. If no address is specifiy, the > + environment variable $fdt_addr is used as first fallback, the address of > + U-Boot's internal device-tree $fdtcontroladdr as second fallback. > + When using ACPI no device-tree shall be specified. > + > +image_size > + Size of the UEFI binary file. This argument is only needed if *image_addr* > + does not match the address of the last loaded UEFI binary. > + > Note > UEFI binaries that are contained in FIT images are launched via the > *bootm* command. > -- > 2.34.1 >