From: sbabic@denx.de
To: Francesco Dolcini <francesco.dolcini@toradex.com>,u-boot@lists.denx.de
Subject: [PATCH v1 1/2] mx6: ddr: Restore ralat/walat in write level calibration
Date: Tue, 12 Apr 2022 20:45:18 +0200 (CEST) [thread overview]
Message-ID: <20220412184521.5D1A183E45@phobos.denx.de> (raw)
In-Reply-To: <20220406115325.98086-2-francesco.dolcini@toradex.com>
> The current DDR write level calibration routine always overwrite
> the ralat/walat fields to their maximum value, just save
> the existing values at the beginning of the calibration routine
> and restore it at the end.
> In case the delay is estimated by the user to be more than one cycle the
> walat should be configured according to that, this is not
> automatically done. From the i.MX6 RM:
> The user should read the results of the associated delay-line at
> MPWLDECTRL#[WL_DL_ABS_OFFSET#] and in case the user estimates that the
> reasonable delay may be above 1 cycle then the user should indicate it at
> MPWLDECTRL#[WL_CYC_DEL#]. Moreover the user should indicate it in
> MDMISC[WALAT] field. For example, if the result of the write leveling calibration
> is 100/256 parts of a cycle, but the user estimates that the delay is above 2 cycles
> then MPWLDECTRL#[WL_CYC_DEL#] should be configured to 2, so the total
> delay will be 2 and 100/256 parts of a cycle
> Probably it would just possible to not overwrite the mdmisc register in
> the first place, since this is not present in the write_level_calib() example
> in NXP AN4467 nor in the i.MX6 RM (44.11.6.1 Hardware Write Leveling
> Calibration).
> Fixes: d339f16911c7 ("arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> Reviewed-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
next prev parent reply other threads:[~2022-04-12 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 11:53 [PATCH v1 0/2] imx6 ddr initialization fixes Francesco Dolcini
2022-04-06 11:53 ` [PATCH v1 1/2] mx6: ddr: Restore ralat/walat in write level calibration Francesco Dolcini
2022-04-06 12:56 ` Fabio Estevam
2022-04-12 18:45 ` sbabic [this message]
2022-04-06 11:53 ` [PATCH v1 2/2] mx6: ddr: Wait before issuing the first MRS cmd Francesco Dolcini
2022-04-06 12:57 ` Fabio Estevam
2022-04-12 18:46 ` sbabic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412184521.5D1A183E45@phobos.denx.de \
--to=sbabic@denx.de \
--cc=francesco.dolcini@toradex.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox