From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70CA8C433EF for ; Wed, 13 Apr 2022 14:22:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 408E083E28; Wed, 13 Apr 2022 16:22:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="JXN0eeQd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8A76383DE7; Wed, 13 Apr 2022 16:22:00 +0200 (CEST) Received: from mail-wm1-x349.google.com (mail-wm1-x349.google.com [IPv6:2a00:1450:4864:20::349]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A8D9783DE7 for ; Wed, 13 Apr 2022 16:21:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=3hdxWYgYKBrISkUmddYggYdW.Ugem-Tggldaklk.VWfp.VW@flex--ascull.bounces.google.com Received: by mail-wm1-x349.google.com with SMTP id j20-20020a05600c1c1400b0038eb5cb35ecso2895796wms.9 for ; Wed, 13 Apr 2022 07:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=KPuIzs6icQWiN44pdTnaHfcRFQITaYx9f8bY104NZgM=; b=JXN0eeQd+1aEgSmuOFgv+Vo+wSWw92S6Tlz64OOI3oMPX2BKlA5OccZFBX6ZEpbfey a6Pv7QCCGvcBXsFovCP9UslPCfKgiHQ7WAod4DzCHVTWXPVxarnqGk/yZqHJbmQ5acJe ukkGO+ERSv2Ap2Roy5IOLFyj+BGx6O+RVdgikQtNIT1Toy6VqcaaxdXJYymNisDq8hxd 86ZreiDJzSkMk8HYd20zilDr5PMO6A8+BxaRh9PWmsxlVP56E4iG8GQP8c5jWHa/XN0p 1AYzk2ON8RLy5Y/YtVnEtTNLKVLGI+tsY0CnbM8dNlYz1HA9Kg9i+/HDwOA4GAxF+WYa b/KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=KPuIzs6icQWiN44pdTnaHfcRFQITaYx9f8bY104NZgM=; b=S4k0pdOkeVL56HWTrn6N8WsESYqWq5MjPyAUshXs/PHj+r+DuvGYHtTdpYAFrG/x9p YbUSE7wKd99lSk6Z/zVn9sUsJMJkRWE4T6nUp55zfeV7aYraR2XQMfauaCRcouky+HRt XeDR4Xp5RCegodCxdAd7TDv9zP/+YBH2o6GnQBhLBvomzru78nvAB5rv0mNYY431QXrm +UT0XD2Nk16y3UXtOr4iPCxpLpLGnc1mHhNoOhe50ahO6S0tleTA4ZtK6v80nYo26bE2 IwsIIidD3M5jtgbGnGCgkh4gHEiTwJPSJPKxwXyq9W2DBEvbtgjt29GWIpWXdeTFmyg4 elMw== X-Gm-Message-State: AOAM533ftz7CaDbXNvE6YLn61u6XD6EDlXjBr92qFP2qXSwkeiFHHY8C Dcrle/GS2L54lofofE3sVd6ln/0kcKP8+XoZty9nCdsTDDLyjw+YrwjSjrZJx0Jtk+AtU6/A0td W4PhCc57v2SXQfJ/2bIZQXZia/Un5pgjBtFUpog+fvkGQUTRAZ0Vg2baI24c= X-Google-Smtp-Source: ABdhPJy2lWkSnvEDHllIaLCoEoE0GWVw8xcZDIxSmlNauNIYu4zEaXqxpYtNNl8g8IH4c4wCqEXmx33nrgU= X-Received: from ascull.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:1510]) (user=ascull job=sendgmr) by 2002:a05:600c:a44:b0:38e:3ce3:3148 with SMTP id c4-20020a05600c0a4400b0038e3ce33148mr8897480wmq.26.1649859717250; Wed, 13 Apr 2022 07:21:57 -0700 (PDT) Date: Wed, 13 Apr 2022 14:21:31 +0000 In-Reply-To: <20220413142137.560987-1-ascull@google.com> Message-Id: <20220413142137.560987-7-ascull@google.com> Mime-Version: 1.0 References: <20220413142137.560987-1-ascull@google.com> X-Mailer: git-send-email 2.35.1.1178.g4f1659d476-goog Subject: [PATCH v2 06/12] virtio: sandbox: Fix device features bitfield From: Andrew Scull To: u-boot@lists.denx.de Cc: sjg@chromium.org, trini@konsulko.com, Andrew Scull Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean The virtio sandbox transport was setting the device features value to the bit index rather than shifting a bit to the right index. Fix this using the bit manipulation macros. Signed-off-by: Andrew Scull Reviewed-by: Simon Glass --- drivers/virtio/virtio_sandbox.c | 2 +- test/dm/virtio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_sandbox.c b/drivers/virtio/virtio_sandbox.c index aafb7beb94..a73b123454 100644 --- a/drivers/virtio/virtio_sandbox.c +++ b/drivers/virtio/virtio_sandbox.c @@ -160,7 +160,7 @@ static int virtio_sandbox_probe(struct udevice *udev) struct virtio_dev_priv *uc_priv = dev_get_uclass_priv(udev); /* fake some information for testing */ - priv->device_features = VIRTIO_F_VERSION_1; + priv->device_features = BIT_ULL(VIRTIO_F_VERSION_1); uc_priv->device = VIRTIO_ID_BLOCK; uc_priv->vendor = ('u' << 24) | ('b' << 16) | ('o' << 8) | 't'; diff --git a/test/dm/virtio.c b/test/dm/virtio.c index adef10592c..aa4e3d778e 100644 --- a/test/dm/virtio.c +++ b/test/dm/virtio.c @@ -77,7 +77,7 @@ static int dm_test_virtio_all_ops(struct unit_test_state *uts) ut_assertok(virtio_get_status(dev, &status)); ut_asserteq(0, status); ut_assertok(virtio_get_features(dev, &features)); - ut_asserteq(VIRTIO_F_VERSION_1, features); + ut_asserteq_64(BIT_ULL(VIRTIO_F_VERSION_1), features); ut_assertok(virtio_set_features(dev)); ut_assertok(virtio_find_vqs(dev, nvqs, vqs)); ut_assertok(virtio_del_vqs(dev)); -- 2.35.1.1178.g4f1659d476-goog