public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Merlijn Wajer <merlijn@wizzup.org>, Tom Rini <trini@konsulko.com>
Cc: maemo-leste@lists.dyne.org, u-boot@lists.denx.de
Subject: [UNTESTED PATCH] Nokia RX-51: Convert to CONFIG_DM_SERIAL
Date: Wed, 13 Apr 2022 21:34:14 +0200	[thread overview]
Message-ID: <20220413193414.16759-1-pali@kernel.org> (raw)

For CONFIG_DM_SERIAL it is required to increase CONFIG_SYS_MALLOC_F_LEN as
default value is not enough for memory hungry CONFIG_DM_SERIAL code.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
Who has serial console on the real device, please test this patch if
serial console is still working. I do not have adapter for serial
console so I tested this patch only in qemu.
---
 board/nokia/rx51/rx51.c      | 12 ++++++++++++
 configs/nokia_rx51_defconfig |  5 ++---
 include/configs/nokia_rx51.h |  1 -
 3 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/board/nokia/rx51/rx51.c b/board/nokia/rx51/rx51.c
index 621cff095619..460d248eaaeb 100644
--- a/board/nokia/rx51/rx51.c
+++ b/board/nokia/rx51/rx51.c
@@ -32,6 +32,7 @@
 #include <i2c.h>
 #include <video.h>
 #include <keyboard.h>
+#include <ns16550.h>
 #include <asm/global_data.h>
 #include <asm/io.h>
 #include <asm/setup.h>
@@ -788,3 +789,14 @@ U_BOOT_DRVINFOS(rx51_video) = {
 U_BOOT_DRVINFOS(rx51_kp) = {
 	{ "rx51_kp" },
 };
+
+static const struct ns16550_plat rx51_serial = {
+	.base = CONFIG_SYS_NS16550_COM3,
+	.reg_shift = 2,
+	.clock = CONFIG_SYS_NS16550_CLK,
+	.fcr = UART_FCR_DEFVAL,
+};
+
+U_BOOT_DRVINFOS(rx51_uart) = {
+	{ "omap_serial", &rx51_serial },
+};
diff --git a/configs/nokia_rx51_defconfig b/configs/nokia_rx51_defconfig
index d5688c7a212b..68acf01e9aeb 100644
--- a/configs/nokia_rx51_defconfig
+++ b/configs/nokia_rx51_defconfig
@@ -11,12 +11,12 @@ CONFIG_STATIC_MACH_TYPE=y
 CONFIG_MACH_TYPE=1955
 CONFIG_SYS_TEXT_BASE=0x80008000
 CONFIG_SYS_MALLOC_LEN=0xc0000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_TARGET_NOKIA_RX51=y
 CONFIG_SYS_LOAD_ADDR=0x80000000
 CONFIG_OPTIMIZE_INLINING=y
 CONFIG_LTO=y
-# CONFIG_SYS_MALLOC_F is not set
 # CONFIG_FIT is not set
 CONFIG_BOOTDELAY=30
 CONFIG_AUTOBOOT_KEYED=y
@@ -70,8 +70,7 @@ CONFIG_DM_KEYBOARD=y
 # CONFIG_MMC_VERBOSE is not set
 CONFIG_MMC_OMAP_HS=y
 CONFIG_MTD=y
-CONFIG_CONS_INDEX=3
-CONFIG_SYS_NS16550=y
+CONFIG_DM_SERIAL=y
 CONFIG_SPI=y
 CONFIG_USB=y
 CONFIG_USB_MUSB_UDC=y
diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h
index e837b12b568f..f273e243e55d 100644
--- a/include/configs/nokia_rx51.h
+++ b/include/configs/nokia_rx51.h
@@ -43,7 +43,6 @@
 #define V_NS16550_CLK		48000000		/* 48MHz (APLL96/2) */
 
 #define CONFIG_SYS_NS16550_SERIAL
-#define CONFIG_SYS_NS16550_REG_SIZE	(-4)
 #define CONFIG_SYS_NS16550_CLK		V_NS16550_CLK
 
 /*
-- 
2.20.1


             reply	other threads:[~2022-04-13 19:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 19:34 Pali Rohár [this message]
2022-05-07 15:16 ` [UNTESTED PATCH] Nokia RX-51: Convert to CONFIG_DM_SERIAL Merlijn Wajer
2022-05-07 17:12   ` Tom Rini
2022-05-07 17:17 ` Merlijn Wajer
2022-05-09 20:18 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220413193414.16759-1-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=maemo-leste@lists.dyne.org \
    --cc=merlijn@wizzup.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox