From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v7 09/15] disk: Correct the conditions for SPL
Date: Thu, 14 Apr 2022 17:21:52 +0900 [thread overview]
Message-ID: <20220414082152.GE32435@laputa> (raw)
In-Reply-To: <20220228141657.1388834-3-sjg@chromium.org>
Hi Simon,
On Mon, Feb 28, 2022 at 07:16:51AM -0700, Simon Glass wrote:
> These filesystems may have different settings for SPL and TPL. Use the
> correct Makefile variable to handle this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v7:
> - Add new patch to correct the conditions for SPL
>
> disk/Makefile | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/disk/Makefile b/disk/Makefile
> index 6ce5a687b3..83f5af6069 100644
> --- a/disk/Makefile
> +++ b/disk/Makefile
> @@ -6,8 +6,8 @@
> #ccflags-y += -DET_DEBUG -DDEBUG
>
> obj-$(CONFIG_PARTITIONS) += part.o
> -obj-$(CONFIG_$(SPL_)MAC_PARTITION) += part_mac.o
> -obj-$(CONFIG_$(SPL_)DOS_PARTITION) += part_dos.o
> -obj-$(CONFIG_$(SPL_)ISO_PARTITION) += part_iso.o
> -obj-$(CONFIG_$(SPL_)AMIGA_PARTITION) += part_amiga.o
> -obj-$(CONFIG_$(SPL_)EFI_PARTITION) += part_efi.o
> +obj-$(CONFIG_$(SPL_TPL_)MAC_PARTITION) += part_mac.o
> +obj-$(CONFIG_$(SPL_TPL_)DOS_PARTITION) += part_dos.o
> +obj-$(CONFIG_$(SPL_TPL_)ISO_PARTITION) += part_iso.o
> +obj-$(CONFIG_$(SPL_TPL_)AMIGA_PARTITION) += part_amiga.o
> +obj-$(CONFIG_$(SPL_TPL_)EFI_PARTITION) += part_efi.o
While none of CONFIG_TPL_xxx_PARTITION is defined,
how do those rules work for TPL?
-Takahiro Akashi
> --
> 2.35.1.574.g5d30c73bfb-goog
>
next prev parent reply other threads:[~2022-04-14 8:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 14:16 [PATCH v7 00/15] vpl: Introduce a verifying program loader Simon Glass
2022-02-28 14:16 ` [PATCH v7 01/15] doc: Convert SPL documentation to ReST Simon Glass
2022-02-28 14:16 ` [PATCH v7 02/15] doc: Expand SPL docs to explain the phase and config Simon Glass
2022-02-28 14:16 ` [PATCH v7 03/15] test: Tidy up test building with SPL Simon Glass
2022-02-28 14:16 ` [PATCH v7 04/15] bloblist: Correct Kconfig dependencies Simon Glass
2022-02-28 14:16 ` [PATCH v7 05/15] avb: Don't build in SPL Simon Glass
2022-02-28 14:16 ` [PATCH v7 06/15] Makefile: Simplify devicetree rules for SPL/TPL Simon Glass
2022-02-28 14:16 ` [PATCH v7 07/15] Makefile: Tidy up the TPL build rules Simon Glass
2022-02-28 14:16 ` [PATCH v7 08/15] Add a default for TPL_TEXT_BASE Simon Glass
2022-02-28 14:16 ` [PATCH v7 09/15] disk: Correct the conditions for SPL Simon Glass
2022-04-14 8:21 ` AKASHI Takahiro [this message]
2022-04-14 12:31 ` Tom Rini
2022-04-15 3:52 ` AKASHI Takahiro
2022-02-28 14:16 ` [PATCH v7 10/15] fdt: Correct condition for SEPARATE_BSS Simon Glass
2022-02-28 14:16 ` [PATCH v7 11/15] fdt: sandbox: Avoid looking for an appended device tree Simon Glass
2022-02-28 14:16 ` [PATCH v7 12/15] binman: Add VPL support Simon Glass
2022-09-12 16:48 ` Simon Glass
2022-02-28 14:16 ` [PATCH v7 13/15] Introduce Verifying Program Loader (VPL) Simon Glass
2022-02-28 14:16 ` [PATCH v7 14/15] vpl: Add Kconfig options for VPL Simon Glass
2022-02-28 14:16 ` [PATCH v7 15/15] sandbox: Add a build " Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414082152.GE32435@laputa \
--to=takahiro.akashi@linaro.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox