Re: [PATCH v2 03/12] sandbox: Migrate getopt section to linker list

Tom Rini
2022-04-29T15:11:30Z

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

On Thu, Apr 14, 2022 at 01:59:32PM +0000, Andrew Scull wrote:

> Use the common infrastructure to create a linker list of the sandbox
> command line flags rather than using a custom method.
>
> The list is changed from containing pointers to containing structs and
> the uses are updated accordingly.
>
> Signed-off-by: Andrew Scull <ascull@google.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> arch/sandbox/cpu/os.c | 21 ++++++++++-----------
> arch/sandbox/cpu/start.c | 10 +++++-----
> arch/sandbox/cpu/u-boot-spl.lds | 6 ------
> arch/sandbox/cpu/u-boot.lds | 6 ------
> arch/sandbox/include/asm/getopt.h | 19 ++++++++++++-------
> arch/sandbox/include/asm/sections.h | 25 -------------------------
> 6 files changed, 27 insertions(+), 60 deletions(-)

This particular test causes all of the pytest infrastructure to fail. I
believe "make qcheck" will show this, even, for a possibly easier
reproducer.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]