From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82BDEC433EF for ; Fri, 15 Apr 2022 03:52:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 62B7C82A53; Fri, 15 Apr 2022 05:52:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="SaTNOh/g"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AA38A83826; Fri, 15 Apr 2022 05:52:55 +0200 (CEST) Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 90B6C8191C for ; Fri, 15 Apr 2022 05:52:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x42a.google.com with SMTP id b15so6442572pfm.5 for ; Thu, 14 Apr 2022 20:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Mgm0YcREBVoaHmQRM+/uMfQ7O5e4X1cueb4nAPz84jw=; b=SaTNOh/goLNijb4T6r+zkiEPXF084SeXWNY1ieBu/Tjozgnpo/9+CxQj4yMvRZlTW8 Vd3LoAqH5oJKEcOWiFsoRg1bSg1y0UawZjE0xvUDoTUrkz1Nh3KWtWvbcXbu12ZMbqjd ckHyol/5Nke2DRLtyhjaTLKmFAepH4y5VkkKelXV1oX5YrTS1yPhgwVlDMv890zREdj3 V6zmY/goldhmM+PwKfD8oc2++owVH6Ql6UTMUVDdH/6sjCMvB01IBP2ooZisZcj7tMhD eYKCSW9KnSaEvqsvsi/w+8vB93A2BBSFn/Z4uzAefMNzEkHTZ/XJgKhxoDO7R1EmX1df LRHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Mgm0YcREBVoaHmQRM+/uMfQ7O5e4X1cueb4nAPz84jw=; b=bu8NqgYHkeLnoYa/xHOs+Ek7KuvxJKyOgwSFgMxSF3Rl/dTf7kvzsJ0j+qAee543AO ku35ycO7eBvBchrolq2NsCMWcKQQwOwfkZ5RoZc2K8LHP2TqjNcRjup363ARvDNP+7HX GASi+qYmaJJqYOs3wXFLIadOPGlA06J0vPbalX/cN5zi/RWw34wSvH/X07ivGZpKWa7A ksSJHVJ29PvS3HvuIpe4qASkZFrXNtdQPDQ4zBGL+s7dfqkY8ItgaBB9BWPPjW0zx3/g bws2dedjQ6J0TK7l9zrvPPVusqVoXt2gpOJ/5Hik9Wfe8kKqfTSFIrfPPHgu+yW95euR TmWw== X-Gm-Message-State: AOAM531p43Xd5WuoYjKuk2F+wQw/er0mdbds3Yx2wZPnbl8VFuaGRaEW wq8azP8Xk/leKbYIY6hhXOdP+w== X-Google-Smtp-Source: ABdhPJw3V40ucxiQPLYjyBGZ3VywjJDWNDUYhOMXTjnPol3/XyH5EtTenn3gOCLrBItvCxjTlbLGYw== X-Received: by 2002:a63:3f0e:0:b0:386:1d94:312a with SMTP id m14-20020a633f0e000000b003861d94312amr4874360pga.317.1649994770820; Thu, 14 Apr 2022 20:52:50 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:18f3:1e4:6c4:6ea3]) by smtp.gmail.com with ESMTPSA id c17-20020a056a00249100b00508389d6a7csm1298422pfv.39.2022.04.14.20.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 20:52:50 -0700 (PDT) Date: Fri, 15 Apr 2022 12:52:47 +0900 From: AKASHI Takahiro To: Tom Rini Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH v7 09/15] disk: Correct the conditions for SPL Message-ID: <20220415035247.GB53581@laputa> Mail-Followup-To: AKASHI Takahiro , Tom Rini , Simon Glass , U-Boot Mailing List References: <20220228141657.1388834-1-sjg@chromium.org> <20220228141657.1388834-3-sjg@chromium.org> <20220414082152.GE32435@laputa> <20220414123112.GY14282@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414123112.GY14282@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, Apr 14, 2022 at 08:31:12AM -0400, Tom Rini wrote: > On Thu, Apr 14, 2022 at 05:21:52PM +0900, AKASHI Takahiro wrote: > > Hi Simon, > > > > On Mon, Feb 28, 2022 at 07:16:51AM -0700, Simon Glass wrote: > > > These filesystems may have different settings for SPL and TPL. Use the > > > correct Makefile variable to handle this. > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > Changes in v7: > > > - Add new patch to correct the conditions for SPL > > > > > > disk/Makefile | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/disk/Makefile b/disk/Makefile > > > index 6ce5a687b3..83f5af6069 100644 > > > --- a/disk/Makefile > > > +++ b/disk/Makefile > > > @@ -6,8 +6,8 @@ > > > #ccflags-y += -DET_DEBUG -DDEBUG > > > > > > obj-$(CONFIG_PARTITIONS) += part.o > > > -obj-$(CONFIG_$(SPL_)MAC_PARTITION) += part_mac.o > > > -obj-$(CONFIG_$(SPL_)DOS_PARTITION) += part_dos.o > > > -obj-$(CONFIG_$(SPL_)ISO_PARTITION) += part_iso.o > > > -obj-$(CONFIG_$(SPL_)AMIGA_PARTITION) += part_amiga.o > > > -obj-$(CONFIG_$(SPL_)EFI_PARTITION) += part_efi.o > > > +obj-$(CONFIG_$(SPL_TPL_)MAC_PARTITION) += part_mac.o > > > +obj-$(CONFIG_$(SPL_TPL_)DOS_PARTITION) += part_dos.o > > > +obj-$(CONFIG_$(SPL_TPL_)ISO_PARTITION) += part_iso.o > > > +obj-$(CONFIG_$(SPL_TPL_)AMIGA_PARTITION) += part_amiga.o > > > +obj-$(CONFIG_$(SPL_TPL_)EFI_PARTITION) += part_efi.o > > > > While none of CONFIG_TPL_xxx_PARTITION is defined, > > how do those rules work for TPL? > > The makefile logic means that if the options are added then they would > work as intended. With the options not being in Kconfig they'll simply > never be evaluated to y. Okay, so it is intentional. But I believe that the changes made around disk/ are not enough. For instance, in include/part.h, there still exist a couple of #ifdef CONFIG_PARTITIONS So some functions are nullified even if SPL_PARTITIONS (and particular partition table types) is enabled. I'm trying to fix some of issues when addressing the issue: https://lists.denx.de/pipermail/u-boot/2022-April/481258.html -Takahiro Akashi > > -- > Tom