From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5676C433F5 for ; Fri, 15 Apr 2022 12:09:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D2DDF83AD0; Fri, 15 Apr 2022 14:08:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="B2ma4P8t"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF3C6839C3; Fri, 15 Apr 2022 14:08:23 +0200 (CEST) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0E11983D9B for ; Fri, 15 Apr 2022 14:08:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id bb38so5827553qtb.3 for ; Fri, 15 Apr 2022 05:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Evn3qgb5hVds6/pcggy3jRaidxr0bbj9N8jEopVVJVQ=; b=B2ma4P8tKsU14wQpDb/HI5sF9lUEQwWaCEILeQlhyHRjpfg3m0BClV+/969rjW3+q9 +mIeo08HdtWM6CipbBsM0e6KmFEntj9gy6AgCTrWjqNOpcpGhqDJFPtp8IEHYPiqnMhD bG65gHyA4s7tDgN5WlMfHozd1eI8G+wqNXv/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Evn3qgb5hVds6/pcggy3jRaidxr0bbj9N8jEopVVJVQ=; b=AAKIKgmjIfbq1tRLE8JhhZTF90DfuB4B31kRueMvqXv8fCojx7t26MVoTF7pLRuFuh UiURnCwQGseqKTA+cGfmDJaR1OytbWnKFNGqUmZpZkfSEswg0ztCVUjF9UV3vQufiK3p In5Tgp83DIRlfhdbK83ugUF/Uth1SgG3B4hipLt9MzP7pPN6lvgRnBk23kLsIvUaqBTP JRlbaGsJ2nxZ5zSz0yAAAMGqZcQt48gRHXr1eEEHESM4wBxsoXRHAll+TFhsvzONW5lH E3GU3hqW46sn5R3eUc4H/kSiN0hSfEzOJr+Eeq+YImhBWb00h8k6uQVR51lfgG95oK9T Un8g== X-Gm-Message-State: AOAM530hJMWYjydw0P4vNWW/UoWkmVLifAj7qXKIoCgMTzWgU+vglaxa L7ix/iC+GzPdyaj0j5Xc2bqgI1Z2I9mPsg== X-Google-Smtp-Source: ABdhPJx/wS1l0PJD6r2KNZoSRKhbNUAHr9IwFvPDx7xSl7TerskLRBtX3HRv/b1ER9PVMg1a7WkHjQ== X-Received: by 2002:ac8:5a47:0:b0:2ed:13d6:bd60 with SMTP id o7-20020ac85a47000000b002ed13d6bd60mr4951086qta.371.1650024499932; Fri, 15 Apr 2022 05:08:19 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id t10-20020a05620a034a00b0069c06c95bf7sm2344644qkm.14.2022.04.15.05.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 05:08:19 -0700 (PDT) Date: Fri, 15 Apr 2022 08:08:17 -0400 From: Tom Rini To: Sean Anderson Cc: Simon Glass , Liviu Dudau , u-boot@lists.denx.de, Linus Walleij , Andre Przywara Subject: Re: [PATCH 1/4] serial: Fix _serial_puts using \n\r instead of \r\n Message-ID: <20220415120817.GP14282@bill-the-cat> References: <20220404181800.2258698-1-sean.anderson@seco.com> <20220404181800.2258698-2-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MmcS8j0TnNedMIm0" Content-Disposition: inline In-Reply-To: <20220404181800.2258698-2-sean.anderson@seco.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --MmcS8j0TnNedMIm0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 04, 2022 at 02:17:57PM -0400, Sean Anderson wrote: > A string like "test\n" would be broken up into the following sequence of > prints by _serial_puts: >=20 > puts("test\n") > putc('\r') >=20 > Although functionally this is the same as \r\n, it is not the standard > sequence and caused tests to fail. Fix this by excluding the '\n' from > the initial print. The above string will now be broken up like >=20 > puts("test") > puts("\r\n") >=20 > Since we may now need to call ops->puts twice (with the associated retry > logic), break that part of the function off into a helper. >=20 > Fixes: 7a76347189 ("serial: dm: Add support for puts") > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! --=20 Tom --MmcS8j0TnNedMIm0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJZYDEACgkQFHw5/5Y0 tyyCNQwAo2pFQisqD34W6BR4cBQ4v6V07+m1iUpqK6vDs7TOqfgT/znOa35zATyb DFk4MudQjihQKVs9iMy95FPCbwBjU9ukanprrFpiIMbxIKxcDfQ/55XNUUOYPSAl ilz/TYhZPpnM0TRstJ4aFJcMT0WFKDAVMSyHp4GO1JmcoalALK//X/z1wg3Blq99 Ubcd0UWtbbX5OyBit/83lMGwsRSzXxER9r8deiZN1sgcC6IfmsnZj7XaaG7W5pVV U4KRMgFxnSdywhp9dGSA5pQOZO6zYv7Qd5JSN7Ba2zvXbu2vOLcYFERxaHfcREIf 1B8/eTCB2wLtF8QUcmiwIRdx2JBam1/RJo2TWg3a4JY48+/DjtTA6N5JTdoNGJYY N7ChOjBsiUgciTSYYPr0YAuOfPO2r4ZiEty/9KlKGvSJ9gcA5FWsvOl9ZWPjm7LU JqVQCPTPebbg518w7PLS2yIbLhyjHtv08gMM5I44aaoEvIqWJG/vf69LmNbH6hKK u9kJ42eL =6LRL -----END PGP SIGNATURE----- --MmcS8j0TnNedMIm0--