public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Dave Gerlach <d-gerlach@ti.com>, Lukasz Majewski <lukma@denx.de>,
	Sean Anderson <seanga2@gmail.com>, Peng Fan <peng.fan@nxp.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Simon Glass <sjg@chromium.org>, Suman Anna <s-anna@ti.com>,
	Nishanth Menon <nm@ti.com>,
	Aswath Govindraju <a-govindraju@ti.com>,
	Bryan Brattlof <bb@ti.com>,
	u-boot@lists.denx.de, Georgi Vlaev <g-vlaev@ti.com>
Subject: Re: [PATCH 02/11] dt-bindings: pinctrl: k3: Introduce pinmux definitions for AM62
Date: Fri, 15 Apr 2022 12:27:52 -0400	[thread overview]
Message-ID: <20220415162752.GC14282@bill-the-cat> (raw)
In-Reply-To: <20220415140931.490047-3-vigneshr@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

On Fri, Apr 15, 2022 at 07:39:22PM +0530, Vignesh Raghavendra wrote:
> From: Suman Anna <s-anna@ti.com>
> 
> Add pinctrl macros for AM62x SoCs. These macro definitions are similar
> to that of previous platforms, but adding new definitions to avoid any
> naming confusions in the SoC dts files.
> 
> checkpatch insists the following error exists:
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> However, we do not need parentheses enclosing the values for this
> macro as we do intend it to generate two separate values as has been
>  done for other similar platforms.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
>  include/dt-bindings/pinctrl/k3.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h
> index 63e038e36c..a5204ab91d 100644
> --- a/include/dt-bindings/pinctrl/k3.h
> +++ b/include/dt-bindings/pinctrl/k3.h
> @@ -41,4 +41,7 @@
>  #define J721S2_IOPAD(pa, val, muxmode)		(((pa) & 0x1fff)) ((val) | (muxmode))
>  #define J721S2_WKUP_IOPAD(pa, val, muxmode)	(((pa) & 0x1fff)) ((val) | (muxmode))
>  
> +#define AM62X_IOPAD(pa, val, muxmode)		(((pa) & 0x1fff)) ((val) | (muxmode))
> +#define AM62X_MCU_IOPAD(pa, val, muxmode)	(((pa) & 0x1fff)) ((val) | (muxmode))
> +
>  #endif

I assume this is being submitted to upstream linux as well?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2022-04-15 16:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15 14:09 [PATCH 00/11] TI: Add support for AM62 SoC Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 01/11] drivers: mmc: am654_sdhci: Add new compatible " Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 02/11] dt-bindings: pinctrl: k3: Introduce pinmux definitions for AM62 Vignesh Raghavendra
2022-04-15 16:27   ` Tom Rini [this message]
2022-04-15 16:36     ` Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 03/11] soc: ti: k3-socinfo: Add entry for AM62X SoC family Vignesh Raghavendra
2022-04-15 21:00   ` Bryan Brattlof
2022-04-15 14:09 ` [PATCH 04/11] arm: mach-k3: Introduce the basic files to support AM62 Vignesh Raghavendra
2022-04-15 16:27   ` Tom Rini
2022-04-15 16:38     ` Vignesh Raghavendra
2022-04-15 17:41       ` Tom Rini
2022-04-16  6:47         ` Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 05/11] arm: mach-k3: am62: Introduce autogenerated SoC data Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 06/11] dma: ti: Add PSIL data for AM62x DMASS Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 07/11] arm: dts: Introduce base AM62 SoC dtsi files Vignesh Raghavendra
2022-04-15 16:28   ` Tom Rini
2022-04-15 16:40     ` Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 08/11] board: ti: Introduce the basic files to support AM62 SK board Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 09/11] arm: dts: Add support for AM62-SK Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 10/11] configs: Add configs for AM62x SK Vignesh Raghavendra
2022-04-15 14:09 ` [PATCH 11/11] doc: ti: Add readme " Vignesh Raghavendra
2022-04-15 20:15   ` Bryan Brattlof
2022-04-18 14:56   ` Andrew Davis
2022-04-18 18:49     ` Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220415162752.GC14282@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=a-govindraju@ti.com \
    --cc=bb@ti.com \
    --cc=d-gerlach@ti.com \
    --cc=g-vlaev@ti.com \
    --cc=jh80.chung@samsung.com \
    --cc=lukma@denx.de \
    --cc=nm@ti.com \
    --cc=peng.fan@nxp.com \
    --cc=s-anna@ti.com \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox