From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDE79C433EF for ; Fri, 15 Apr 2022 17:42:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0D5698390C; Fri, 15 Apr 2022 19:42:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qLqrI+Ay"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6E0E183894; Fri, 15 Apr 2022 19:41:59 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7E7238390C for ; Fri, 15 Apr 2022 19:41:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id a11so6324639qtb.12 for ; Fri, 15 Apr 2022 10:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hfTKDMM5QjQzQrwTOGXGFSy9lyRRRIBv12OPEIF2D1Q=; b=qLqrI+AyXpqTHb7SmzFsUqxI9gh1R3UPGB/PFTA3kofHbqNyWNPEmx7WKOJqsSw2yQ xSBpWLoIyMluPlKdb7LYF29hcOohmFQCsrdr/cH7K7JAG21j7zI1uHhGhiLkr1T+pCLK fBdpWbvN/fmAEYg+R2L6uLppMtHn2ZmszvXII= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hfTKDMM5QjQzQrwTOGXGFSy9lyRRRIBv12OPEIF2D1Q=; b=niQclGXumIPLECLdeyBras2rGtuZaf/I/XPqlgPA3yS2YIQ2E9Rg/M+uls0T8Ej/7m mHRyuy7Owo99RArnFE0qBsjfod8onM236te2GbjiD7IQOVcYU6ZMKVWc0sWGWimkA1dr KKI1MgugGElXCD9Dc0EJIi2xPmPzYJpv5iwGKRHqripDOUwvCTMzrgAWkH35t1RDgr+b 8cxjhOydzD6RCZFT0FFCSir+XXPcY2qFpw4POzPmkLP3FdBP5mUP2Urj2bYSKrilIvLd tffSu4xX7mQblIxjI2eWQ9Xq89iV33YC8XTHExsDWLyVdnB3H5rUZZlKFfUtg/O83MQI yr5Q== X-Gm-Message-State: AOAM5313YpunIY4xZv3WrUKeq1d0yKm3WPTv91QcqlXw/ssFeWiqx9A8 YFKqONfMziIaeFcER0YhaonnyA== X-Google-Smtp-Source: ABdhPJzRvkDDB1VxqODx5QM1kdwKF/KEPloQDY7070asWYTkFV6widra88QcrLTmzIcpQSZ/ucc6BA== X-Received: by 2002:ac8:7157:0:b0:2ed:1600:6969 with SMTP id h23-20020ac87157000000b002ed16006969mr221676qtp.121.1650044514232; Fri, 15 Apr 2022 10:41:54 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id c131-20020a379a89000000b0069c903625absm1563266qke.102.2022.04.15.10.41.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 10:41:53 -0700 (PDT) Date: Fri, 15 Apr 2022 13:41:51 -0400 From: Tom Rini To: Vignesh Raghavendra Cc: Dave Gerlach , Lukasz Majewski , Sean Anderson , Peng Fan , Jaehoon Chung , Simon Glass , Suman Anna , Nishanth Menon , Aswath Govindraju , Bryan Brattlof , u-boot@lists.denx.de, Georgi Vlaev Subject: Re: [PATCH 04/11] arm: mach-k3: Introduce the basic files to support AM62 Message-ID: <20220415174151.GF14282@bill-the-cat> References: <20220415140931.490047-1-vigneshr@ti.com> <20220415140931.490047-5-vigneshr@ti.com> <20220415162745.GB14282@bill-the-cat> <671fac45-c933-0a86-6e90-b155608aee85@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mCbnuTGJQNFGyeNn" Content-Disposition: inline In-Reply-To: <671fac45-c933-0a86-6e90-b155608aee85@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --mCbnuTGJQNFGyeNn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 15, 2022 at 10:08:32PM +0530, Vignesh Raghavendra wrote: >=20 >=20 > On 15/04/22 9:57 pm, Tom Rini wrote: > > On Fri, Apr 15, 2022 at 07:39:24PM +0530, Vignesh Raghavendra wrote: > >=20 > > [snip] > >> diff --git a/arch/arm/mach-k3/am625_init.c b/arch/arm/mach-k3/am625_in= it.c > >> new file mode 100644 > >> index 0000000000..ee902a774e > >> --- /dev/null > >> +++ b/arch/arm/mach-k3/am625_init.c > >> @@ -0,0 +1,254 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * AM625: SoC specific initialization > >> + * > >> + * Copyright (C) 2020-2022 Texas Instruments Incorporated - https://w= ww.ti.com/ > >> + * Suman Anna > >> + */ > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include "common.h" > >> +#include > >> +#include > >> +#include > >=20 > > Er, common.h twice?=20 >=20 > Second one refers to arch/arm/mach-k3/common.h OK, lets rename that, and see what info there we can put elsewhere. > > Please re-check this, and then also drop common.h > > (here and elsewhere) as it only includes other headers and we should > > avoid it when possible. =20 >=20 > Sure, will do. >=20 > > In fact, checkpatch.pl complains about both > > dm.h and common.h so please address series-wide, thanks. > >=20 >=20 > Unfortunately, it doesn't ;( Ah, right. It only checks for inside of headers. But still should be avoided. --=20 Tom --mCbnuTGJQNFGyeNn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJZrlUACgkQFHw5/5Y0 tyzNKQv/Xr8+BWJErO1XegisCM41k4iKimt4Y6+TzsZJNgvMYcZ2uFdJHa8R4uRk 6Wo4MhXJnOcaquyXg/zZPcpZ9lNFN6UdbaAakPPiz9vj2XrtSMuT32LYAiAm9Mxv fub1Eu29IwlsBEo0d+7nNuXfjZp9Pc2grY8tsAoAMzAu5HoNPBratJ6zG54O9Wx4 EeQvHYW6at7vDaUg825CuN5bOWVIHWS+d0LuaZheIHRD9ZzjluIUN0BS/FidER5B XQ8yWnxqt2AyRsv6adsGSNjV5o/L972Da2lJ2hJyVv1i5h29FJPfcFEWFLaIF1cd kEOkuUVWYo8ICkMSTYvkwK8y+gQxw4y9GTL/Qew9cG7g/PtazFmqbnTPO9cPs7EW tyOwfSmv/v7B/8p9dd3lfCwGX7Fs3h9z8v5OkHvI35HLO7TDyCxQ1ceToMnqx0YN FMSCE5TJZrgXXVNNZnKjS2uO6m4R4X0rFKS3pIWx2KJfNC8PSDTrj7odQFFjkk5s yDwLaMKY =kpFQ -----END PGP SIGNATURE----- --mCbnuTGJQNFGyeNn--