From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8138BC433F5 for ; Mon, 18 Apr 2022 08:15:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2373A837EF; Mon, 18 Apr 2022 10:15:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="SmW/JzvZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 21C8783826; Mon, 18 Apr 2022 10:15:06 +0200 (CEST) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 59A6082FA8 for ; Mon, 18 Apr 2022 10:15:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x632.google.com with SMTP id c23so11836168plo.0 for ; Mon, 18 Apr 2022 01:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=EFJId3WgDiha0L/akG3RTpNEHyIyC0qGMmm3ozxpGpI=; b=SmW/JzvZTOYtVY0DfB/+DfTvNid7vYls4VTKgAaBKvXfZOHQ+pn+rgeG1NNdp4D6i4 YcFNcj9u54UvU47eoaEtzl14SiGUyxQp5wRoiGZePMRQvuavIlh7WZdrjHx4w3+QRstf I5pZ5UGnAX+yRnyvKLwP4LsFmhJ6y+qL2e/cqVA1Jr/GiLujF2kMnU+tjXNo5ozxmqRj 8lBWf4FryfbfTPuR8x3fmT2NColjEtVx1b11qRecnCNEsssSbu5GzA93RBS3jmF4eYoY 0PwZ17DCDI8zEXp349Zbwdj+XftEAZGo3t1zTyQzTWbOaXThDzVDyPkk3/0ofzSlTt2W vHEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=EFJId3WgDiha0L/akG3RTpNEHyIyC0qGMmm3ozxpGpI=; b=6H2vrQP7xI/Wn+sGZwgt3W9tLFj7PTLYNmk67MetUn1bz3NNmswgFo0OzCVAM2hkuu fiW9nvuZjPFYamJ9//4cZWniSIevHD7sMCKjjkVbTd9qkOwhYr3NUl03VCjfh7TjTlyj 7tJCqV88tMnJA3kHCasY2su/0eXzRlQEG4w/s0Eft4UJYskZccXfcDMpgaNMohqZJUbQ tRXIT7vqbYxKNqHG5UUeLFpBruenAutnuQHN706xBDFRILPv1KtBg20urChMm9I4nVU9 aGsPWsMKAjF/uC5hIuB3lHBlZvs/EKxARr0G3Gavk+WfRjfv2iku9CmlHCFmlQeB0Vk7 VjGw== X-Gm-Message-State: AOAM533JKWHm/0zCKZZdO+UUNBrfc5s2xqASg0su03A3OJXs2h125oN+ CKCT6IlKIx8P2JmnUEs+Vpn2h5hGSR8nAg== X-Google-Smtp-Source: ABdhPJy9bTlwCFixsXvAvwLljExVwATmglalbM8R37aDlTu1vjjkzecpj8BKpM34IdKeCYIZ+yCs9Q== X-Received: by 2002:a17:90b:3e83:b0:1d2:615e:9a2d with SMTP id rj3-20020a17090b3e8300b001d2615e9a2dmr9842271pjb.234.1650269700620; Mon, 18 Apr 2022 01:15:00 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:c5bd:cefa:475:fe1c]) by smtp.gmail.com with ESMTPSA id mu1-20020a17090b388100b001c77e79531bsm16849735pjb.50.2022.04.18.01.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 01:15:00 -0700 (PDT) Date: Mon, 18 Apr 2022 17:14:56 +0900 From: AKASHI Takahiro To: Tom Rini Cc: sjg@chromium.org, alex.nemirovsky@cortina-access.com, xypron.glpk@gmx.de, u-boot@lists.denx.de Subject: Re: [RFC] disk: don't compile in partition support for spl/tpl if not really necessary Message-ID: <20220418081456.GC36317@laputa> Mail-Followup-To: AKASHI Takahiro , Tom Rini , sjg@chromium.org, alex.nemirovsky@cortina-access.com, xypron.glpk@gmx.de, u-boot@lists.denx.de References: <20220415071156.122261-1-takahiro.akashi@linaro.org> <20220416030148.GH14282@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220416030148.GH14282@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Tom, Thank you for evaluating the code growth. On Fri, Apr 15, 2022 at 11:01:48PM -0400, Tom Rini wrote: > On Fri, Apr 15, 2022 at 04:11:56PM +0900, AKASHI Takahiro wrote: > > We see some increase of spl code size due to partition support (disk/*) > > while none of particular partition types (CONFIG_SPL_XXX_PARTITION) are > > enabled. > > With this patch applied, part.c is no longer included unless really > > necessary. > > > > In addition, fix errors in CI build revealed after this change is made. > > > > Fixes: commit 88ca8e26958b ("disk: Add an option for partitions in SPL") > > Fixes: commit 17f8cda505e3 ("efi_loader: set partition GUID in device path > > for SIG_TYPE_GUID") > > Signed-off-by: AKASHI Takahiro > > --- > > cmd/Kconfig | 1 + > > configs/cortina_presidio-asic-emmc_defconfig | 1 - > > So, the defconfig change here is wrong, CMD_PART isn't being implied > otherwise, As I said in my reply to Heinrich, this defconfig seems weird. but that's okay as I found another workaround. > and this board is part of a number of boards that had > EFI_LOADER before, but not DOS_PARTITION, and so do grow, but in a > valid/expected way. There are also a number of boards that don't have > any partition type support set, but that too I think ends up being > correct. The whole before/after is at > https://gist.github.com/trini/731ee8d50a9bc96b90e12860f8c53f14 That happens, probably, because EFI_LOADER is by default enabled for most platforms whether users want to use UEFI or not. I don't think that people who want to use UEFI with U-Boot will be much careful of the code increase by this change. Anyway, I will drop this hunk("select DOS_PARTITION) in the next version as I found another way to fix the dependency issue. -Takahiro Akashi > -- > Tom