public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH 1/2] imx8mn_evk: Enable cache in SPL
@ 2022-04-18 17:15 Fabio Estevam
  2022-04-18 17:15 ` [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR Fabio Estevam
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Fabio Estevam @ 2022-04-18 17:15 UTC (permalink / raw)
  To: sbabic; +Cc: u-boot, peng.fan, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

There is no reason for disabling I-cache and D-cache
in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 configs/imx8mn_evk_defconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/configs/imx8mn_evk_defconfig b/configs/imx8mn_evk_defconfig
index b2981d1e3692..e661b3ba7e55 100644
--- a/configs/imx8mn_evk_defconfig
+++ b/configs/imx8mn_evk_defconfig
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SYS_MALLOC_LEN=0x2000000
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR
  2022-04-18 17:15 [PATCH 1/2] imx8mn_evk: Enable cache in SPL Fabio Estevam
@ 2022-04-18 17:15 ` Fabio Estevam
  2022-04-22  8:46   ` sbabic
  2022-04-28  9:00   ` Peng Fan (OSS)
  2022-04-22  8:46 ` [PATCH 1/2] imx8mn_evk: Enable cache in SPL sbabic
  2022-04-28  9:00 ` Peng Fan (OSS)
  2 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2022-04-18 17:15 UTC (permalink / raw)
  To: sbabic; +Cc: u-boot, peng.fan, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

The imx8mn_evk target have been converted to use binman.

With the binman approach the ATF load address is described via
devicetree, so remove the now unneeded instruction of exporting
ATF_LOAD_ADDR.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 doc/board/nxp/imx8mn_evk.rst | 1 -
 1 file changed, 1 deletion(-)

diff --git a/doc/board/nxp/imx8mn_evk.rst b/doc/board/nxp/imx8mn_evk.rst
index 711545af896a..c45bb7bac7a1 100644
--- a/doc/board/nxp/imx8mn_evk.rst
+++ b/doc/board/nxp/imx8mn_evk.rst
@@ -42,7 +42,6 @@ Build U-Boot
 
    $ export CROSS_COMPILE=aarch64-poky-linux-
    $ make imx8mn_ddr4_evk_defconfig
-   $ export ATF_LOAD_ADDR=0x960000
    $ make
 
 Burn the flash.bin to MicroSD card offset 32KB:
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR
  2022-04-18 17:15 ` [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR Fabio Estevam
@ 2022-04-22  8:46   ` sbabic
  2022-04-28  9:00   ` Peng Fan (OSS)
  1 sibling, 0 replies; 6+ messages in thread
From: sbabic @ 2022-04-22  8:46 UTC (permalink / raw)
  To: Fabio Estevam, u-boot

> From: Fabio Estevam <festevam@denx.de>
> The imx8mn_evk target have been converted to use binman.
> With the binman approach the ATF load address is described via
> devicetree, so remove the now unneeded instruction of exporting
> ATF_LOAD_ADDR.
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] imx8mn_evk: Enable cache in SPL
  2022-04-18 17:15 [PATCH 1/2] imx8mn_evk: Enable cache in SPL Fabio Estevam
  2022-04-18 17:15 ` [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR Fabio Estevam
@ 2022-04-22  8:46 ` sbabic
  2022-04-28  9:00 ` Peng Fan (OSS)
  2 siblings, 0 replies; 6+ messages in thread
From: sbabic @ 2022-04-22  8:46 UTC (permalink / raw)
  To: Fabio Estevam, u-boot

> From: Fabio Estevam <festevam@denx.de>
> There is no reason for disabling I-cache and D-cache
> in SPL.
> Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
> CONFIG_SPL_SYS_DCACHE_OFF options.
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] imx8mn_evk: Enable cache in SPL
  2022-04-18 17:15 [PATCH 1/2] imx8mn_evk: Enable cache in SPL Fabio Estevam
  2022-04-18 17:15 ` [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR Fabio Estevam
  2022-04-22  8:46 ` [PATCH 1/2] imx8mn_evk: Enable cache in SPL sbabic
@ 2022-04-28  9:00 ` Peng Fan (OSS)
  2 siblings, 0 replies; 6+ messages in thread
From: Peng Fan (OSS) @ 2022-04-28  9:00 UTC (permalink / raw)
  To: Fabio Estevam, sbabic@denx.de
  Cc: u-boot@lists.denx.de, Peng Fan, Fabio Estevam



On 2022/4/19 1:15, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> There is no reason for disabling I-cache and D-cache
> in SPL.
> 
> Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
> CONFIG_SPL_SYS_DCACHE_OFF options.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
>   configs/imx8mn_evk_defconfig | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/configs/imx8mn_evk_defconfig b/configs/imx8mn_evk_defconfig
> index b2981d1e3692..e661b3ba7e55 100644
> --- a/configs/imx8mn_evk_defconfig
> +++ b/configs/imx8mn_evk_defconfig
> @@ -1,6 +1,4 @@
>   CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>   CONFIG_ARCH_IMX8M=y
>   CONFIG_SYS_TEXT_BASE=0x40200000
>   CONFIG_SYS_MALLOC_LEN=0x2000000
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR
  2022-04-18 17:15 ` [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR Fabio Estevam
  2022-04-22  8:46   ` sbabic
@ 2022-04-28  9:00   ` Peng Fan (OSS)
  1 sibling, 0 replies; 6+ messages in thread
From: Peng Fan (OSS) @ 2022-04-28  9:00 UTC (permalink / raw)
  To: Fabio Estevam, sbabic@denx.de
  Cc: u-boot@lists.denx.de, Peng Fan, Fabio Estevam



On 2022/4/19 1:15, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The imx8mn_evk target have been converted to use binman.
> 
> With the binman approach the ATF load address is described via
> devicetree, so remove the now unneeded instruction of exporting
> ATF_LOAD_ADDR.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>   doc/board/nxp/imx8mn_evk.rst | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/doc/board/nxp/imx8mn_evk.rst b/doc/board/nxp/imx8mn_evk.rst
> index 711545af896a..c45bb7bac7a1 100644
> --- a/doc/board/nxp/imx8mn_evk.rst
> +++ b/doc/board/nxp/imx8mn_evk.rst
> @@ -42,7 +42,6 @@ Build U-Boot
>   
>      $ export CROSS_COMPILE=aarch64-poky-linux-
>      $ make imx8mn_ddr4_evk_defconfig
> -   $ export ATF_LOAD_ADDR=0x960000
>      $ make
>   
>   Burn the flash.bin to MicroSD card offset 32KB:
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-04-28  9:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-18 17:15 [PATCH 1/2] imx8mn_evk: Enable cache in SPL Fabio Estevam
2022-04-18 17:15 ` [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR Fabio Estevam
2022-04-22  8:46   ` sbabic
2022-04-28  9:00   ` Peng Fan (OSS)
2022-04-22  8:46 ` [PATCH 1/2] imx8mn_evk: Enable cache in SPL sbabic
2022-04-28  9:00 ` Peng Fan (OSS)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox