From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2957C433F5 for ; Tue, 19 Apr 2022 03:09:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C6E5A83A9F; Tue, 19 Apr 2022 05:09:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Wutg787w"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DFCF180544; Tue, 19 Apr 2022 05:09:44 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6D8DA83A9F for ; Tue, 19 Apr 2022 05:09:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id e128so10465392qkd.7 for ; Mon, 18 Apr 2022 20:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xe0JwwpN4SUhUH/ojxlcYUXG4HtYv55RGmDi/f5BsWI=; b=Wutg787wRKkGrbO/AqXX+o9UfTxSOQA5ctcJEWiuX5OPT6AO9qfgAvr/ZaZHWWDPIC uvLS0gayDBW26ZvFJqZ9hFYDMYdd3/Im58TSD11MzQ0WFcu/u5LdtphsmnzP0JU+LFjl oU7R7McOi+kr8QjclYDOd01CW8YYKaSiSqhMA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xe0JwwpN4SUhUH/ojxlcYUXG4HtYv55RGmDi/f5BsWI=; b=CMdFjy+Fn9+O6xpyJPtzqYA/4LWet5rKrdL939onAUgxmiT+2CyvnoStq9NlThVNVp ownZQFN54oq53UG1Oyz1emVwXqoTSxfQbZ4nzGA4xsV80DNEctUNkftam7TodhJLZpiJ jPfzqNCtwsRF6/lZh1q3C8FNvlHJHOy2NSsMLizhMNPIMO5of3d/6akg4wLF3Trp4O7A NucJDA4BcJJCO7FyreoPB0mirZIMiEVuR/VSRlXl5LVsVBQHZYliN0t9pT4X8tMfh6hk DVFw5r9dbdEXlG4eHF13jQ6aRqILfm1wZWETvotbNw6Ju+5YOJCzkshRbSD/OmKSB0/O PnMw== X-Gm-Message-State: AOAM531pyQlvlHT9H31XCdeOK8N0XXPCHYWl1fR8kqWLdhHk//HRgdRl M7y6vze+6BBZDSBHm44wS+ceJg== X-Google-Smtp-Source: ABdhPJzCXlTJ2LyZpiq8smasJVOLwV8U5ES8PtBs81I+dzXxQbl2sIU6I4l+CHel4j8AYIZFA2OQ5w== X-Received: by 2002:a05:620a:24c4:b0:69e:a0ad:ff5d with SMTP id m4-20020a05620a24c400b0069ea0adff5dmr4344218qkn.11.1650337781182; Mon, 18 Apr 2022 20:09:41 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id m9-20020a05622a118900b002f1fc51135dsm3544676qtk.57.2022.04.18.20.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 20:09:40 -0700 (PDT) Date: Mon, 18 Apr 2022 23:09:38 -0400 From: Tom Rini To: AKASHI Takahiro Cc: sjg@chromium.org, xypron.glpk@gmx.de, u-boot@lists.denx.de Subject: Re: [PATCH 3/7] disk: define nullified functions for !PARTITIONS Message-ID: <20220419030938.GE3045430@bill-the-cat> References: <20220419010158.47034-1-takahiro.akashi@linaro.org> <20220419010158.47034-4-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline In-Reply-To: <20220419010158.47034-4-takahiro.akashi@linaro.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 19, 2022 at 10:01:54AM +0900, AKASHI Takahiro wrote: > Some defconfig enables CMD_PART even if none of any partition table > types (CONFIG_*_PARTITION) are enabled. > This will lead to the size growth in SPL/TPL code since disk/part.c > will be compiled in any way. > We will change disk/Kconfig later so that CONFIG_PARTITIONS is only > enabled when, at least, one of CONFIG_*_PARTITION is enabled. >=20 > To make the build work (in particular, "part" command) correctly, > a few functions should be defined as void functions in case of > !CONFIG_PARTITIONS. >=20 > Signed-off-by: AKASHI Takahiro I guess I wonder why we don't just make CMD_PART depend on PARTITIONS now and thus correct the few (single?) board that has this enabled without underlying partition code by removing the can't be functional cmd. --=20 Tom --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJeJ+8ACgkQFHw5/5Y0 tyxb6gv+OQGRTw6VyqWCfcHsMiE3GWjEMzb7y0aD0uyDyXyYMpOe1reddy0S0y0Q 2gymgwRw4A44QaiCqy2khgXFMnoXhfBpo8cEqi6xWM6o+c0lq/WMqysiXs4FVZ7m ESFNwRI8SUkvxImuTEDs4NuSHrlS4vsrQErrfTwHuJA1/8XTedSyZTuSHlSdghsJ YRdmudRDF5MmqX5SDzwyY09SoXsp0egonadOENdxP2wzmUvjToZCpdPvMg4zPmBo /AZMCF3YN8afDWBl70ukPWThkklMyVCL5czWhBgz1htzp36+gEmU7tWZWGUWkJSD Ag4EHDWyeQRmIgfWK5f28cjhcb0/wNX0ChzbKiXRzOJCb4wTOTiBhg4lEq11x8nh hr/MK2WinmrAN2tXIJdtxz0tcVBoaXw9M3RQKnQ3kmoo+4g18xEVNYpaBVBgW4Qo EqYqtDUPSbW3lr1rJnR7ZfKJZ/yL1OFgvZ7+eXA25FPkgoTYCHV1wpoiXQNFhPt+ fN5Q5Fal =JHE8 -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s--