From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81A67C433EF for ; Tue, 19 Apr 2022 04:11:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8EC6083AD1; Tue, 19 Apr 2022 06:11:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="OdNaxxzL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 82BFE83AD1; Tue, 19 Apr 2022 06:11:31 +0200 (CEST) Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A3F5F839A7 for ; Tue, 19 Apr 2022 06:11:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x536.google.com with SMTP id k14so22671234pga.0 for ; Mon, 18 Apr 2022 21:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=hdAorjK/vb3nIDmSUk/PJgFtYv1VJFwLm4Xk8Q2aSAA=; b=OdNaxxzLnHPjv+00wWBhyFftPPncJ7oHXu+nb7yVN8jytNJDHOqr7cZ3BY/L+fYRAk L/bSfZc8USDxzCNSfcebxOeB0mLoDupE6wA59q8hDMDAzbWupJbuuVOZCgS1FzYmC6Co x5fRZfgFr5gMub8khUIOyutyTzfrAyou8beMZIsPpDuqHKraHh0k27yXS9J9bL7Em/zW 7Rl55vPXNXr2YjytE1elhDHkeMs/Az4fC9yfC7p3mIrNkE+ybBNQQWDlP6rk/la1SfUe I8rzd7lZKGjvYq6Wka4yZ/u9e7dwdHHJAML4TFM8S8hZJ96nVddjztc4OML0vNJzOXdg EgKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=hdAorjK/vb3nIDmSUk/PJgFtYv1VJFwLm4Xk8Q2aSAA=; b=n0Gv2lq8ztdMW0VfLDHHOTMXgKDproY7KSOrHnfI+PlOc58y9KU1aGpwV7haw7brSq 6ooalXQBKgn9hzyq4R0usu6redgWK9qvw9veUOB0tKkEEQUeHK/8uhO6a0AwTJ7bAlPl tc3GbaNz7/8ufO2nK4aY75huhlRUlkvnIixs++0pLQ+s48BeRKc0kpQiZH0+OOyEVN5J krzx6x9CHhjqezMweW0kd3XV0kjX9tykERcrOQ4pHToIdRblGvzusuPNmBoRxjyj4lB/ h782yXDIbvMbJEujpAQ3k6JkrOF75AAv+VcUWcqYIYZOGeS8wfDWzxOnppalyeGW2PB6 2Mjg== X-Gm-Message-State: AOAM532Nk4DZ5ubGULIGgQhnyrtg39VK1FW/B5E5HXChxGcwON6L4HKI BUnRvvj5Rm3BqOu5c18CoemZ1A== X-Google-Smtp-Source: ABdhPJyyNmxNVVIs8uiDZqVKwSP3ryX5fz6p5DrHwrWkwU3y0vzLmhutAyH3kqG9gEF4uDleU0iHZQ== X-Received: by 2002:a63:fc18:0:b0:39c:f431:8310 with SMTP id j24-20020a63fc18000000b0039cf4318310mr12563265pgi.433.1650341486840; Mon, 18 Apr 2022 21:11:26 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:5858:d3a6:5cad:ceeb]) by smtp.gmail.com with ESMTPSA id g17-20020a625211000000b005056a6313a7sm14167059pfb.87.2022.04.18.21.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 21:11:26 -0700 (PDT) Date: Tue, 19 Apr 2022 13:11:23 +0900 From: AKASHI Takahiro To: Tom Rini Cc: sjg@chromium.org, xypron.glpk@gmx.de, u-boot@lists.denx.de Subject: Re: [PATCH 3/7] disk: define nullified functions for !PARTITIONS Message-ID: <20220419041123.GA51109@laputa> Mail-Followup-To: AKASHI Takahiro , Tom Rini , sjg@chromium.org, xypron.glpk@gmx.de, u-boot@lists.denx.de References: <20220419010158.47034-1-takahiro.akashi@linaro.org> <20220419010158.47034-4-takahiro.akashi@linaro.org> <20220419030938.GE3045430@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419030938.GE3045430@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, Apr 18, 2022 at 11:09:38PM -0400, Tom Rini wrote: > On Tue, Apr 19, 2022 at 10:01:54AM +0900, AKASHI Takahiro wrote: > > > Some defconfig enables CMD_PART even if none of any partition table > > types (CONFIG_*_PARTITION) are enabled. > > This will lead to the size growth in SPL/TPL code since disk/part.c > > will be compiled in any way. > > We will change disk/Kconfig later so that CONFIG_PARTITIONS is only > > enabled when, at least, one of CONFIG_*_PARTITION is enabled. > > > > To make the build work (in particular, "part" command) correctly, > > a few functions should be defined as void functions in case of > > !CONFIG_PARTITIONS. > > > > Signed-off-by: AKASHI Takahiro > > I guess I wonder why we don't just make CMD_PART depend on PARTITIONS > now and thus correct the few (single?) board that has this enabled > without underlying partition code by removing the can't be functional > cmd. Well, that is partially what I did in my RFC and I thought that you declined to accept my change. Did I misunderstand you? -Takahiro Akashi > -- > Tom