From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 966A5C433F5 for ; Tue, 19 Apr 2022 12:12:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BBF0783B4E; Tue, 19 Apr 2022 14:12:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="K2JvufaS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1EBEC83B4D; Tue, 19 Apr 2022 14:12:16 +0200 (CEST) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E915783B4E for ; Tue, 19 Apr 2022 14:12:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2b.google.com with SMTP id d9so12942903qvm.4 for ; Tue, 19 Apr 2022 05:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/jvSbYXG+hrUn+WtbVl0+oZVJGbbDeSd4aUwEMDw19o=; b=K2JvufaSEDpgbQngKi7qR3iZeQx7hFsxV8ilZMhiB60N4hcIwnzj2tiGw4WTQkSY4a R1ZmbTNbWC6e2vMgVmH1SZiBHnaQAIzFDsSlaYkuqpu0Pgg1qIV7K3yv7Jt2ZRFmDpZJ ZwIGqB7yQ3elqvaspFqBTOoPCfYv6r3BBOgiY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/jvSbYXG+hrUn+WtbVl0+oZVJGbbDeSd4aUwEMDw19o=; b=KEE1EcLa8ino8Z6aaZK6KhApJxHIMaHoaCOVuIef3pa3LUtUViBXsIRqQAxjLjRtHK EoetLS6gA/J1etLgKjc770ATncQ43qS1NsWsDx1rP/NaTT2kYpr10kruFvgmAUA7rkac CmbfK4StRqRTOWsqumL/dgBV+KBrhAQonKApP9uELo5DuoSjeHrd4iaXxQuF/E+hQzGx Hrjhy6biBVBbVakceACrbSUWzV6etMwLVSFspPXdu46cypaaVQD9sBbXZnCwp2YtuoqV 5iv4tJqyVP3yLzHpeWsr7l91NLQAUzS2kCp3sd//6Y6/ixtXrYMGA32jXK+WiznoMMT6 5HTw== X-Gm-Message-State: AOAM5303dhVB/5M/3se41LVDf3dFgfAMHgvw8vVLG8iC8JwQnG6OVJTS 9OcUn8Mg58WGp1mVesqW/paXxA== X-Google-Smtp-Source: ABdhPJxDz6wmqRPiq7qRMtAl/43+DR0vqeHKab+fcGBQz4XBOGJ9ELVzjEtSXJQH5SNCYkQBuPCwBg== X-Received: by 2002:a05:6214:96c:b0:444:40b9:1d62 with SMTP id do12-20020a056214096c00b0044440b91d62mr11641163qvb.110.1650370330650; Tue, 19 Apr 2022 05:12:10 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id p66-20020a374245000000b0069c387c5449sm8103213qka.9.2022.04.19.05.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 05:12:09 -0700 (PDT) Date: Tue, 19 Apr 2022 08:12:07 -0400 From: Tom Rini To: AKASHI Takahiro Cc: sjg@chromium.org, xypron.glpk@gmx.de, u-boot@lists.denx.de Subject: Re: [PATCH 3/7] disk: define nullified functions for !PARTITIONS Message-ID: <20220419121207.GF3045430@bill-the-cat> References: <20220419010158.47034-1-takahiro.akashi@linaro.org> <20220419010158.47034-4-takahiro.akashi@linaro.org> <20220419030938.GE3045430@bill-the-cat> <20220419041123.GA51109@laputa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IrhDeMKUP4DT/M7F" Content-Disposition: inline In-Reply-To: <20220419041123.GA51109@laputa> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --IrhDeMKUP4DT/M7F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 19, 2022 at 01:11:23PM +0900, AKASHI Takahiro wrote: > On Mon, Apr 18, 2022 at 11:09:38PM -0400, Tom Rini wrote: > > On Tue, Apr 19, 2022 at 10:01:54AM +0900, AKASHI Takahiro wrote: > >=20 > > > Some defconfig enables CMD_PART even if none of any partition table > > > types (CONFIG_*_PARTITION) are enabled. > > > This will lead to the size growth in SPL/TPL code since disk/part.c > > > will be compiled in any way. > > > We will change disk/Kconfig later so that CONFIG_PARTITIONS is only > > > enabled when, at least, one of CONFIG_*_PARTITION is enabled. > > >=20 > > > To make the build work (in particular, "part" command) correctly, > > > a few functions should be defined as void functions in case of > > > !CONFIG_PARTITIONS. > > >=20 > > > Signed-off-by: AKASHI Takahiro > >=20 > > I guess I wonder why we don't just make CMD_PART depend on PARTITIONS > > now and thus correct the few (single?) board that has this enabled > > without underlying partition code by removing the can't be functional > > cmd. >=20 > Well, that is partially what I did in my RFC and I thought > that you declined to accept my change. > Did I misunderstand you? Yes, I wasn't clear, sorry for the confusion. Just this part of the series should be replaced with making CMD_PART depend on PARTITIONS and if there really is a use case for 'part' without PARTITION support (rather than it being an unintentionally enabled feature) we can deal with it then. The rest of the series looks good to me and I'll let Heinrich comment on the EFI specific parts. --=20 Tom --IrhDeMKUP4DT/M7F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJepw0ACgkQFHw5/5Y0 tyx/agv/csIOzXW7HMYwC8+/L4J0OoBG984K7zQi8x0nMDdvSBKLQmS/ug+rCTGK 34HCZw/lDN3b2ICTO/dmuuZ3xb7ZrUiCHttVjF3Z/EgXwgYBg6i7HApZ0abhzJpm 3gf2o8dabM/pMNssVst+KA2yPOXqSNF1EWpsewMTHHQi/rEnzT2d1R9nGXDzDKWk xEIOtTErLcoJM2czX2WhtO8PeHPvFvkOxwh3OVzdva6erGrOUJJtFaGKrVpYVHX5 qylj6Qw1FI9yHYfF5ale4UvHZprWfW7Y+wfrNmpBPnaohVk30hEMgsaDT9zckxmX KMUJIa3tF2G5db+HWnJ6brZj7H8TtfbQx3tm2m9adbORCL6seEmunzW1p9rV55tL kzvEQ4RNRKEbLwAPEvCF3/ZVOz6q56WbtS1gRD4dmI/UD30q2Bx+I0FdBYMUzQk7 +KP3vNRFpYsEYoH12q7ZlevRfjNI7ah0wq2BLql28khjvJNl+awLyZabxpQMkSYQ /sZOswFN =uplJ -----END PGP SIGNATURE----- --IrhDeMKUP4DT/M7F--