From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EE81C433F5 for ; Wed, 20 Apr 2022 13:12:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB00183E42; Wed, 20 Apr 2022 15:12:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Wqh9gQ9P"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5DAA083E42; Wed, 20 Apr 2022 15:12:13 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 937E483E45 for ; Wed, 20 Apr 2022 15:12:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id j6so1124564qkp.9 for ; Wed, 20 Apr 2022 06:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q0RWdpK/Nca1bMGV8ZziSlsIIIM4Xw4jjQ79cLNhrCE=; b=Wqh9gQ9PABW3a2mCIn7Fa9vHkMgZcj5zsYmRiYMyCPsYRkHOUcPrQD4uXwAdo/iMVA qmnKkY9dNFkZOajshGzhTjErUuTTJZNYlN2tdRlOUDqxeKDaUNI0VZOXGVEvg1KHEc9s n2xnuWVnR6Ly8I8VuUiDR77+9gs/xZfMpeeRI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q0RWdpK/Nca1bMGV8ZziSlsIIIM4Xw4jjQ79cLNhrCE=; b=CDMJztLt/ejr1Rswsea1ya86dd2riELtYHkDlF3g6pnUl+yiDnx9TWvkl1vgfG9U/M bc67UKWOR4hdJWe8R3HlLHWVM81hmwmou1MM5yuAItq/rM/VmQId+KUsdFqIXzYXPHRm Dn5sPJw/3d40dOIj9gpO0v4DDGuxuG3TBQUrkx35NSmeDki7zM02f7Fdnr8cM++4pKqW kjDYDI/qJVkHJ46bIeANs8T1blGmSmB0/G1DgXDjkKR0cYSH80atAYnfxVnKI5oqi47Y w09gyj36Wjo1Br49NL1HhmFOc0GLSHqOuSh4cQ2ZtukgJhDhnTVSrF9mzY2crbR5eEBW 9b9A== X-Gm-Message-State: AOAM531epkjE7ef9FxqceYIFDbuY26Juy7Rv0LggT2WVrj/HKuXc0rqU 5DX5VIohNhGlfWp8+b2m8Bhmtg== X-Google-Smtp-Source: ABdhPJysofPWUyW2m4cf2XjIWa7gnbRGg/cVIIc1bmYjoOfBCcwF9xDPHgjGNgXn66TsCHWYv4ssNA== X-Received: by 2002:a05:620a:4511:b0:69e:e8a6:ce5c with SMTP id t17-20020a05620a451100b0069ee8a6ce5cmr242711qkp.454.1650460324991; Wed, 20 Apr 2022 06:12:04 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id b13-20020ac85bcd000000b002e06856b04fsm1825572qtb.51.2022.04.20.06.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:12:04 -0700 (PDT) Date: Wed, 20 Apr 2022 09:12:02 -0400 From: Tom Rini To: Billy Tsai Cc: ryan_chen@aspeedtech.com, chiawei_wang@aspeedtech.com, BMC-SW@aspeedtech.com, andrew@aj.id.au, u-boot@lists.denx.de Subject: Re: [PATCH] gpio: aspeed: Fix incorrect offset of read back register. Message-ID: <20220420131202.GG3045430@bill-the-cat> References: <20220413053451.2975-1-billy_tsai@aspeedtech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XoSOsMJQ8mz74oyx" Content-Disposition: inline In-Reply-To: <20220413053451.2975-1-billy_tsai@aspeedtech.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --XoSOsMJQ8mz74oyx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 13, 2022 at 01:34:51PM +0800, Billy Tsai wrote: > The offset of the current read back register is the value of the gpio pin, > not the value written for the gpio output. > This patch fix it to avoid the other gpio output value controlled by the > same register being set incorrectly. >=20 > Fixes: 7ad889b0f37a ("gpio: Add Aspeed GPIO driver") > Signed-off-by: Billy Tsai Applied to u-boot/master, thanks! --=20 Tom --XoSOsMJQ8mz74oyx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJgBqIACgkQFHw5/5Y0 tyxzPwwAqbwo7LNbuZdeljY9Ch19aZ5mYGLr0KE31QLuc1ORKIV2IW34M67E0t8b zjosZSAKe58OCYt+gNjOnx51B6cpQLRIBPSYRlKLTnepF4+VsQqVqKS8/3fwEwrV X83WlVLeWeoG2IhclxaVcQMZf0/N9l33VwHQiBN9YLdl06iNmk+A7bP5xOoJ7Xyy j4kHiBEyknugOB5VihunRxEJf5PMO1dDynA/7c2KS6RdXSxtx75sB9DG1LdfNzQ8 8xO7m9AkZsbFt5tNnBCk/N3yfge9SfY9bWK44MKyx08J5YHTM2jGI1o9CMdax1iw I/+TzgYMECiZNqLxzozCnJnf7Gvfd5h0qRy03hWJWFhnip30sYz7jzJMouFhNQL8 B8xXb7+qEW0m0OPktI+qrdvu/8UCiWDddX1CY5IgtxsfwFBQTrECo35so6ahGlNH HJvzRC9T+iIxENBexdicLIT073awPxtqThatq7+nZmCDdMHYLC9pDXHdtTFNf5Eb q/7gElc7 =ZDl6 -----END PGP SIGNATURE----- --XoSOsMJQ8mz74oyx--