From: Tom Rini <trini@konsulko.com>
To: Diego Rondini <diego.rondini@kynetics.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v2] cmd: gpio: Add `gpio read` subcommand
Date: Wed, 20 Apr 2022 15:24:28 -0400 [thread overview]
Message-ID: <20220420192428.GW3045430@bill-the-cat> (raw)
In-Reply-To: <20220411100209.184072-1-diego.rondini@kynetics.com>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Mon, Apr 11, 2022 at 12:02:09PM +0200, Diego Rondini wrote:
> As explained in commit 4af2a33ee5b9 ("cmd: gpio: Make `gpio input`
> return pin value again") the `gpio input` is used in scripts to obtain
> the value of a pin, despite the fact that CMD_RET_FAILURE is
> indistinguishable from a valid pin value.
> To be able to detect failures and properly use the value of a GPIO in
> scripts we introduce the `gpio read` command that sets the variable
> `name` to the value of the pin. Return code of the `gpio read` command
> can be used to check for CMD_RET_SUCCESS or CMD_RET_FAILURE.
> CONFIG_CMD_GPIO_READ is used to enable the `gpio read` command.
>
> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-04-20 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 17:14 [PATCH] cmd: gpio: Add `gpio read` subcommand Diego Rondini
2022-04-08 23:43 ` Tom Rini
2022-04-11 10:02 ` [PATCH v2] " Diego Rondini
2022-04-20 19:24 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420192428.GW3045430@bill-the-cat \
--to=trini@konsulko.com \
--cc=diego.rondini@kynetics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox