From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9279DC433F5 for ; Thu, 21 Apr 2022 00:31:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 926DA83EC0; Thu, 21 Apr 2022 02:31:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="AjHGYKqJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 53C9B83EC2; Thu, 21 Apr 2022 02:31:05 +0200 (CEST) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 04C1A83EAA for ; Thu, 21 Apr 2022 02:31:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x435.google.com with SMTP id p8so3466252pfh.8 for ; Wed, 20 Apr 2022 17:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Dc8I0FQIEX3buvmSp94BhkCObBXG3a8dR1jr8AsdnyE=; b=AjHGYKqJjSL9yyQSjIHKMszjgYqdBB619b6cYpJL1emKjoM+R86f9v/czU7i3aE8IR nACFYkPE2Qe8PmIDY3n7QQltM7yHoXxzQrOcRjPA0kKClDeKuHOH3/3j3rQCDS6bJebE nJE80T2llFGHbqyVs1nqvm/BJbZL8/t+uPPJVeVXzKshl2CXgs3SREFDZ/TYdKfeQLSs MboJq3J78+u9RWNS4SGZN4bjop3lQav/jaEqSwfmM/IDeLQRT0bSte/o8tyFg9/cQZCd PX5oDmkIF+i36YqBIbzmlY+TlsXralES5YnrtudlsKyep43BeDSZif4p1cYAVBa0B0hc 4i0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Dc8I0FQIEX3buvmSp94BhkCObBXG3a8dR1jr8AsdnyE=; b=MiZpvpDBy/JIQ0HGEOufge0WumD5wUWG6JS7yx5/7/pkN1LhUrbcbJI1WCN61ywzuM /FhwVXEjj1F5Ne1SD9x0XPYhmCj5jAexbI/c7MWYbdTpg9wN96wHWNafXrEzXRqaE3Ov gNEl777u7X+hOLHAaLwsqxXZBFI118/GX61viiy3T3L9+K11V9b6z9gCSlaB63IE4/hP VLmh0Bt8v1CHyEENLSpI7uyvXIJQ7D1OpD/62zMEUVJ/FBVOUeguVLM+7DHon0qOG/Fj GtmZ11AGL/4glq9/3M0wFo3ZXNwmVtDv0MXlZZMgEtteXtd4x0iI05u4lpK+zrnVZ/lX q+3A== X-Gm-Message-State: AOAM5324qGYWEP4aM7puD4AXpWBPGKJK20rQntIu/0rjLFauPfwJHi0z mGstkbZDVp6qgX5XSkOiOTcsEA== X-Google-Smtp-Source: ABdhPJzkH4BsL4exvPGY1DTp7BGfA7malrhN+bBA0Z1wKqGeGcggiGyMOpX0jGfm5mzaR6cxyfVi8Q== X-Received: by 2002:a05:6a00:ac1:b0:4f1:29e4:b3a1 with SMTP id c1-20020a056a000ac100b004f129e4b3a1mr26080657pfl.63.1650501059073; Wed, 20 Apr 2022 17:30:59 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:88b4:9a13:801d:9fc8]) by smtp.gmail.com with ESMTPSA id n184-20020a6227c1000000b0050a3bbd36d6sm19945226pfn.204.2022.04.20.17.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 17:30:58 -0700 (PDT) Date: Thu, 21 Apr 2022 09:30:55 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, trini@konsulko.com, sjg@chromium.org Subject: Re: [PATCH 6/7] efi_loader: disk: compile efi_disk when CONFIG_BLK Message-ID: <20220421003055.GA7584@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , u-boot@lists.denx.de, trini@konsulko.com, sjg@chromium.org References: <20220419010158.47034-1-takahiro.akashi@linaro.org> <20220419010158.47034-7-takahiro.akashi@linaro.org> <238f2357-34da-eca0-071d-7cec914fabda@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <238f2357-34da-eca0-071d-7cec914fabda@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, Apr 20, 2022 at 09:42:00AM +0200, Heinrich Schuchardt wrote: > On 4/19/22 03:01, AKASHI Takahiro wrote: > > Now we can build efi_loader with block device support (CONFIG_BLK) and > > without CONFIG_PARTITIONS. > > So change Makefile. > > > > Signed-off-by: AKASHI Takahiro > > --- > > lib/efi_loader/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile > > index 034d26cf0109..aaaa25cefe01 100644 > > --- a/lib/efi_loader/Makefile > > +++ b/lib/efi_loader/Makefile > > @@ -68,7 +68,7 @@ obj-y += efi_watchdog.o > > obj-$(CONFIG_EFI_ESRT) += efi_esrt.o > > obj-$(CONFIG_LCD) += efi_gop.o > > obj-$(CONFIG_DM_VIDEO) += efi_gop.o > > -obj-$(CONFIG_PARTITIONS) += efi_disk.o > > +obj-$(CONFIG_BLK) += efi_disk.o > > Why do we need efi_disk.o if CONFIG_PARTITIONS=n? Why do you think so? As you admitted in your comment at: https://lists.denx.de/pipermail/u-boot/2022-April/481546.html GPT(EFI_PARTITION) is optional under the current implementation ("EFI_LOADER should imply EFI_PARTITION" in your words). As a matter of fact, EFI_LOADER (and efi_disk.o) can be compiled in even without any partition table types. If you don't agree, please drop this patch. I don't care because it won't help reducing SPL code size anyway. -Takahiro Akashi > How can we be UEFI compliant without partition support? > > Best regards > > Heinrich > > > obj-$(CONFIG_NET) += efi_net.o > > obj-$(CONFIG_GENERATE_ACPI_TABLE) += efi_acpi.o > > obj-$(CONFIG_GENERATE_SMBIOS_TABLE) += efi_smbios.o >