From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B2F3C433F5 for ; Thu, 21 Apr 2022 15:43:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E7DC83DB0; Thu, 21 Apr 2022 17:43:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="eKYmGu8q"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DE4D983DB6; Thu, 21 Apr 2022 17:43:46 +0200 (CEST) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EAD0A83BBE for ; Thu, 21 Apr 2022 17:43:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf35.google.com with SMTP id e17so3943902qvj.11 for ; Thu, 21 Apr 2022 08:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yjLYdRriNQJxzUq11dCHZvPKQ9YoVB2oSPGIaXtOyCY=; b=eKYmGu8qDnGyu7I/JO2YwmFmruuS4O//e1XDqBJso8vwZNmjB0ai2EdT2fLV/YdFze BXR1tvMCzi7sle+malE9PoLbGAq4w4lZwAOncVy+fb+l9UzjM8K6hw89fAs1Ytr7aBdM pb5GhuvNquu8MGiwwQDpRfYdBnUOTabvN7Ux8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yjLYdRriNQJxzUq11dCHZvPKQ9YoVB2oSPGIaXtOyCY=; b=qNjzxuaRe8PMSrJnFy7a4QiT30QiRA3k+FcwjMAgCZXK+MWVGaV7H16gvcu5vgDhDT J1HrqacaDH8md5XeABrb1AOyiEmxGht6f/T0yFJZjZR1IrPj5CE1sMlWh3ubnDZpKEeK VI9o2oU4NSD0XxuvBfsWHxENyC+pDcVu9fhQwBJbfeAsskaLfpy2CYqunaP0v5bPrt29 I+R2xC5diD7Bypwpl5CY8wqC/ci90h3/gNLkX6uOD8zicA8NMGb1+wLbKq92Xp3qXuUe TmswIK9OSDkWJuTSmKRkdXSxlyL3jwultCZ22m4GzQMyA5OY4nARH8XAexGSLHQ0cuC5 tc2A== X-Gm-Message-State: AOAM531YLLJ/V2xjifzTThfla2/Iodd6pTFrU0r2an8uv+kgTFDSUgwI 0x2y96Ll8l0UMOyhf65vjOQpJw== X-Google-Smtp-Source: ABdhPJzQBBJyDHHSN2dHrl2fxiV7Afp5WW9rCFdXN7XaNwCYq3Ye0UQwjho2dXE6/hb7D9RnLZCMkQ== X-Received: by 2002:a0c:fd91:0:b0:444:46e9:9556 with SMTP id p17-20020a0cfd91000000b0044446e99556mr19668319qvr.75.1650555821755; Thu, 21 Apr 2022 08:43:41 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id e126-20020a376984000000b0069c86b28524sm3208392qkc.19.2022.04.21.08.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 08:43:40 -0700 (PDT) Date: Thu, 21 Apr 2022 11:43:38 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Adam Ford , Fabio Estevam , Marek =?iso-8859-1?Q?Beh=FAn?= , Peng Fan , Simon Glass , Stefano Babic , Tim Harvey , Tommaso Merciai , Vladimir Oltean Subject: Re: [PATCH 1/3] env: Implement lower priority arch_env_get_location() Message-ID: <20220421154338.GA3045430@bill-the-cat> References: <20220406002134.890426-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="m3NGSFsSaj96nZIx" Content-Disposition: inline In-Reply-To: <20220406002134.890426-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --m3NGSFsSaj96nZIx Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 06, 2022 at 02:21:32AM +0200, Marek Vasut wrote: > Currently there is only one way to override desired environment location, > by implementing env_get_location(). This is increasingly being conflated > both on board level and architecture level, which leads to a problem on > boards where this function is already implemented on architecture level, > since those boards have no way to override this environment location on > board level anymore. >=20 > Implement arch_env_get_location() function which is architecture specific > and should only ever be implemented in architecture code. This function > has lower priority than env_get_location(), which should only ever be > implemented in board code, and which overrides the arch_env_get_location() > architecture environment selection. >=20 > This way, architecture can define its default environment chooser, while > board can now override it as needed at all times. >=20 > There is no functional change, since env_get_location() simply returns > arch_env_get_location(), and arch_env_get_location() implements the > current env_get_location() default content. >=20 > Signed-off-by: Marek Vasut > Cc: Adam Ford > Cc: Fabio Estevam > Cc: Marek Beh=FAn > Cc: Peng Fan > Cc: Simon Glass > Cc: Stefano Babic > Cc: Tim Harvey > Cc: Tom Rini > Cc: Tommaso Merciai > Cc: Vladimir Oltean Applied to u-boot/master, thanks! --=20 Tom --m3NGSFsSaj96nZIx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJhe6QACgkQFHw5/5Y0 tyzY6Av+NTFBrPNxsO8NJYgqHefQhGENb75knkqiLTREIm5TF0M5ToTu7yNejs8I eXOuIZ5BZ7tkSBa26VCv0nZ3m7QyiszAPTOEliphbhdVna7f/HMLX2zvUDhERpCq fsPihL02YyDc9PezO+7xFYLgt2zOar6MwumTnXGuFWT7xsF+/7xSQrZQmaU7bNZp g7hy84BC6DmeLkvCOykKwIWLeM6SdlCdWaRXeQLUS0Q1gXQtGK+s2Q8o1oaeSvEJ WeV0ZCC3/RKznkKU2dmfddOqaqFjumjenmy8SIjT/p4D217ubOdMa6pD0Rq1LBW+ slLGMrWqR4PtZ+0bR9GrHsieec6rR+EtDewyz+w4QHSfUPxL0PSso8QAVOP9TACF /JmjsAh5Tu6/aRY+GYZtbwgkLt8jRb3WB59UHSzssYzh166vuVF4ln++GSMNYIVo e+nozntAFl+TjGsD4qsoXqqHs+aKZ2whwhxp2bu2bi8j/RZBbZbd0mizqrw/RRnU w528Nh4v =w0pk -----END PGP SIGNATURE----- --m3NGSFsSaj96nZIx--