From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9319DC433F5 for ; Thu, 21 Apr 2022 23:58:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B9BF583E30; Fri, 22 Apr 2022 01:57:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="J1zZ+HIy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BD3DC83DC8; Fri, 22 Apr 2022 01:57:20 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 69D9F83D92 for ; Fri, 22 Apr 2022 01:57:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id d14so4467192qtw.5 for ; Thu, 21 Apr 2022 16:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7Ut1S5uMPMlOc+Hi/oVfdTJ9NmfibcB84H/9UlYhk0Q=; b=J1zZ+HIyJgL5WkfgPPvb+pqxZsqvCkZKP4H/HS7PW3O2hkdB2T79dVNXMicRA+dRuM Jdaws24B06B5kecOrKAaHM5/Hm/e2a/uHRVqvbywYOSp71cizaaXVCQD0LLhjq1Bs1Ou 6L0wtfYzDCYeijfpkUXYhEJ5EYybnCeQI6vWI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7Ut1S5uMPMlOc+Hi/oVfdTJ9NmfibcB84H/9UlYhk0Q=; b=b8GWmNjd0mw72CBXsQSq7yb1XFCRNumUF5C88XWcqEXNxhNUn2P1F4Op1VLJQaVSQO aTrJjRrKmcGGyphNkS3aKD2Y2tRyH/FaMv8lo9iFHxNMzvfk4AHNoRAU6qqEPKuCxh6R qSVG2KyLup+iF0bNYnkv7H2laA+6Qa5ZCxG/hYzETObzCmtnoHQvVV+q8auFu3T805Mn m8QfCfrmD55LEC0DtyLmXBZtUSIo57DA3URc3Yj+7uPicO0uSY7afmrRFXcsCBs8eU/t JkqWHfH40cZPrnCH27m9Z4uv7dDNQk+xkbAzPgxkegDXmJJb2n0gCA5kLgn1s1g6ZfpG GlEw== X-Gm-Message-State: AOAM532s/ZuyTWOVjG7qSE3+aVzYGx7uohHzjoTGuGMxqY28cK00NGUH noFe/C2GEVlOI6CAEGdl3g21Kg== X-Google-Smtp-Source: ABdhPJzYZKVi8zXeRuPC5Vg3wdw9bjtDmhkTEx0foCyn9OnFNtoyOvlj1UtihQagdt0AM7fJ3hRFYQ== X-Received: by 2002:ac8:5e4c:0:b0:2e2:2bbf:57fa with SMTP id i12-20020ac85e4c000000b002e22bbf57famr1416954qtx.278.1650585436307; Thu, 21 Apr 2022 16:57:16 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id i63-20020a375442000000b0069eecbf54dfsm231314qkb.28.2022.04.21.16.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 16:57:15 -0700 (PDT) Date: Thu, 21 Apr 2022 19:57:13 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Bin Meng , Adrian Fiergolski , Marek =?iso-8859-1?Q?Beh=FAn?= , Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH 5/5] misc: atsha204a: Remove duplicate CRC-16 implementation Message-ID: <20220421235713.GR3045430@bill-the-cat> References: <20220412092044.25133-1-pali@kernel.org> <20220412092044.25133-6-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+HM+R7/Jd0Fa6H3F" Content-Disposition: inline In-Reply-To: <20220412092044.25133-6-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --+HM+R7/Jd0Fa6H3F Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 12, 2022 at 11:20:44AM +0200, Pali Roh=E1r wrote: > ATSHA204A uses bit-reversed checksum of standard CRC-16 with polynomial > x^16 + x^15 + x^2 + 1. >=20 > This ATSHA204A specific checksum can be calculated just by using common > U-Boot functions bitrev16() and crc16(). >=20 > So replace custom driver CRC-16 implementation by common U-Boot functions. >=20 > Signed-off-by: Pali Roh=E1r > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! --=20 Tom --+HM+R7/Jd0Fa6H3F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJh71kACgkQFHw5/5Y0 tyw50gv+O3BDpIKsNyuWhtALdpipZhfGQ31ehROlOazYPjUE0oIoLFaBNX+36I+d WLU/ZgWuUvHN+QooUaajPZsTeNv2HSe8enA4e6ERjc4RpLp7f/opiRZ5YHfrFacR PfhOg3zPR+V0SxaDWOWawrsVaYzOm6WuWa/mROJp0lbjMlL/OZ563v0/rZ4/S/cc IpaMApFpLwvfrCHzc82lx4VYzsIK9XZ7wm8vzhu+EiofgCCntatDIELzzKagTfEU 1qWRYyd99Hab5twDI+zSiatHLoMTprtMq3kJIBmp16diGonedsU+MEnnGoZQ6irv JEXDEmpkuo2+/yFV7aHIMLjfVRtzc9lFvg2Fa9WJWgfgcoeSTifny5zpq83mGGYb g9JTQTw20/HOjg9hEBBOBrd3dn4Xo99xxX4YOnVirvhdGCHRY+5jO2IgFS+BoG0l 23cRb3b0ikRZey/6uezvCNdPwDjpv5Ri4jKtAzoMIECIHYXbzBRREHdvdbUJAOiw PclKaf5g =RTOL -----END PGP SIGNATURE----- --+HM+R7/Jd0Fa6H3F--