[PATCH v2 0/1] imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

[PATCH v2 0/1] imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

[Ying-Chun Liu]

From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>

Previously there's no implementation of board_fix_fdt(). But commit
35bb60787b88 introduced one in arch/arm/mach-imx/imx8m/soc.c. Since
the board_fix_fdt() in imx8mm-cl-iot-gate is empty, we should remove
it and use the one from soc.c.

v2: reword commit comment

Ying-Chun Liu (PaulLiu) (1):
  imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

 board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 5 -----
 1 file changed, 5 deletions(-)

-- 
2.35.1

[PATCH v2 1/1] imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

[Ying-Chun Liu]

From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>

In arch/arm/mach-imx/imx8m/soc.c there's an implementation of
board_fix_fdt() introduced by commit 35bb60787b88. Remove the
redundant one to avoid failed to build from source when enabling
CONFIG_OF_BOARD_FIXUP.

Signed-off-by: Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: uboot-imx <uboot-imx@nxp.com>
---
v2: reword commit comment
---
 board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c b/board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c
index e6021a4566..3d7fff34d2 100644
--- a/board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c
+++ b/board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c
@@ -335,11 +335,6 @@ static int iot_gate_imx8_update_ext_ied(void)
 	return 0;
 }
 
-int board_fix_fdt(void *rw_fdt_blob)
-{
-	return 0;
-}
-
 int extension_board_scan(struct list_head *extension_list)
 {
 	struct extension *extension = NULL;
-- 
2.35.1

Re: [PATCH v2 1/1] imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

[Fabio Estevam]

Hi Paul,

On Wed, Apr 20, 2022 at 12:37 PM Ying-Chun Liu <grandpaul@gmail.com> wrote:
>
> From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
>
> In arch/arm/mach-imx/imx8m/soc.c there's an implementation of
> board_fix_fdt() introduced by commit 35bb60787b88. Remove the
> redundant one to avoid failed to build from source when enabling
> CONFIG_OF_BOARD_FIXUP.
>
> Signed-off-by: Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: uboot-imx <uboot-imx@nxp.com>
> ---
> v2: reword commit comment

This version looks good:

Reviewed-by: Fabio Estevam <festevam@denx.de>

[PATCH v2 1/1] imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

[sbabic]

> From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
> In arch/arm/mach-imx/imx8m/soc.c there's an implementation of
> board_fix_fdt() introduced by commit 35bb60787b88. Remove the
> redundant one to avoid failed to build from source when enabling
> CONFIG_OF_BOARD_FIXUP.
> Signed-off-by: Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: uboot-imx <uboot-imx@nxp.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================