From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42C00C433F5 for ; Tue, 26 Apr 2022 14:44:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 88FE1839BD; Tue, 26 Apr 2022 16:44:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="WKHHpJ44"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1E84A83A97; Tue, 26 Apr 2022 16:44:28 +0200 (CEST) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 836A48390C for ; Tue, 26 Apr 2022 16:44:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x632.google.com with SMTP id k4so18840563plk.7 for ; Tue, 26 Apr 2022 07:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=HHtA6wjoSYFtAla7Sev3qsLj1XH4uq6r3xyfCSJ+kIM=; b=WKHHpJ44PO8mx7FHIRKaTUQtDw7mMreHnCQKYW4Dcma6urHHlujbCEeYnX7/bsF+fv i/oCKLFr6P+nUvSIQ8KUWFX0wUWWDSApJy7VvUsYD5D8kn8In6Mz8kZtg+/sdIDYiyZb qmz9bcdOQ/xycjSMrwZ5T6PCjXZDE6oaoheYkyVZeBWF7z29JfsYRh/Rao+qtlLaaEyR z7V9LFP8fI+gC2EgcCbEoE7GgyULdrEj5fYW5ZYRNiY0JC6c0nNvIPOVtcEXJDx3Z5OK a6Z8S4vZAg8NgP9yyDyctq9nrNwW0Ub2g7xxYBD2KzM2BJsOBtQ6JXYHWcywvR0CVwsI xNjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=HHtA6wjoSYFtAla7Sev3qsLj1XH4uq6r3xyfCSJ+kIM=; b=y1dgy9GAO/3WBDWYuHZxjMjAwVE+MKXfzZYTpgY7q9EwjQRxlXtbHbrnSmmyVDKbJM KC03vhPr/t1e067rEbPQOT6DK/5zTdDzsYwG2Tjic6Y7qL9KtJvIq3YYs6PZAIPLhQpO sD77IstkcknAksAcBx2GbLw2g0zD8VCDrHUsUJZEaKZUARNrc9qy6I9Bvktk211KsuMq Zg8SbUPOaycT+tN2qK4e/NUMu1sIeBBqO3V0Nx8umL69CZXhiibc/rxzHLK0/UsrS/J5 hi0EIffSp6/uH5/+j5jkQCyOR0WQpQei+pCJt9GXkEarJh9KmWqDeOwf/OF9YOuqAVds ZgNA== X-Gm-Message-State: AOAM531HLp6v2UFALdRbBxspV3n6Dqr8Q4nQMOyM4tfHPV3HiJcmBYLh hbyyz8JsS3IXVY2MkEE3issiJg== X-Google-Smtp-Source: ABdhPJzI5QgZzEbYxAWZ2rqKE8ZHVqLy7N7c4/pSLXS8i/YaS+KwStA9+iH57Xq5UxcTTYAcE514Dw== X-Received: by 2002:a17:90b:601:b0:1d9:5a0f:2017 with SMTP id gb1-20020a17090b060100b001d95a0f2017mr15027338pjb.162.1650984262801; Tue, 26 Apr 2022 07:44:22 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:1478:7fee:797:d232]) by smtp.gmail.com with ESMTPSA id a38-20020a056a001d2600b004fae885424dsm16697153pfx.72.2022.04.26.07.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 07:44:22 -0700 (PDT) Date: Tue, 26 Apr 2022 23:44:18 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: masami.hiramatsu@linaro.org, u-boot@lists.denx.de, sjg@chromium.org, ilias.apalodimas@linaro.org, Tom Rini Subject: Re: [PATCH v5 00/12] efi_loader: more tightly integrate UEFI disks to driver model Message-ID: <20220426144418.GA62529@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , masami.hiramatsu@linaro.org, u-boot@lists.denx.de, sjg@chromium.org, ilias.apalodimas@linaro.org, Tom Rini References: <20220419010517.47175-1-takahiro.akashi@linaro.org> <20220425234421.GA35191@laputa> <4e897c5c-1c49-70ed-2668-40e8d932d5ea@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e897c5c-1c49-70ed-2668-40e8d932d5ea@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Tue, Apr 26, 2022 at 03:57:26PM +0200, Heinrich Schuchardt wrote: > On 4/26/22 01:44, AKASHI Takahiro wrote: > > On Mon, Apr 25, 2022 at 10:43:44PM +0200, Heinrich Schuchardt wrote: > > > On 4/19/22 03:05, AKASHI Takahiro wrote: > > > > With this patch set[1] applied, UEFI subsystem maintains a list of its > > > > disk objects dynamically at runtime based on block device's probing. > > > > (See "issues" and "prerequisite" below.) > > > > > > > > [1] https://github.com/t-akashi/u-boot/tree/efi/dm_disk > > > > > > > > For instance, > > > > => dm tree > > > > Class Index Probed Driver Name > > > > ----------------------------------------------------------- > > > > root 0 [ + ] root_driver root_driver > > > > ... > > > > pci 0 [ + ] pci_generic_ecam |-- pcie@10000000 > > > > ... > > > > ahci 0 [ ] ahci_pci | |-- ahci_pci > > > > scsi 0 [ ] ahci_scsi | | `-- ahci_scsi > > > > usb 0 [ ] xhci_pci | `-- xhci_pci > > > > ... > > > > => efi devices > > > > Missing RNG device for EFI_RNG_PROTOCOL > > > > No EFI system partition > > > > Unable to find TPMv2 device > > > > Device Device Path > > > > ================ ==================== > > > > 000000013eee88d0 /VenHw(..) > > > > 000000013ffeb798 /VenHw(..)/Uart(0,0,D,D) > > > > 000000013eeeb810 /VenHw(..)/MAC(525252525252,1) > > > > => scsi rescan > > > > > > > > > With the series binding block devices after initializing the UEFI > > > sub-system works fine. Also unbinding is reflected in the EFI devices. > > > > > > But this series breaks UEFI compliance. > > > > I don't think so. > > > > > All block devices must be probed > > > before booting. > > > > This (not enumerating all the devices) is also true even before my patch. > > > > > Without this GRUB will not be able to read the boot > > > partition with vmlinuz and initrd. > > > > I'm not sure what you expect here, but > > is it enough to define "preboot" variables with any number of > > enumerating commands, like "scsi rescan", "usb start" and so on? > > I expect that boards that booted with previous versions of U-Boot using > the respective defconfig still boot. But they don't. Here is one example > (orangepi_pc_defconfig): > > Found U-Boot script /boot.scr.uimg > 189 bytes read in 2 ms (91.8 KiB/s) > ## Executing script at 43100000 > 22979 bytes read in 8 ms (2.7 MiB/s) > 98304 bytes read in 8 ms (11.7 MiB/s) > Booting /EFI\debian\grubarm.efi > Welcome to GRUB! > > error: disk `,msdos2' not found. > grub rescue> > > In U-Boot v2022.04 function efi_disk_register() ensured that all block > devices and their partitions were added as EFI handles. Not the all block devices, but the block devices which have already enumerated when efi_init_obj_list() is called. > But that > function is missing now. What (boot) device are you using here? Please show me the values of env variables, particularly, "boot_targets". Please show me the content of boot.scr.uimg, too. Please show me the output from => dm tree => efidebug devices for 2022.04 and 2022.07-rc1. -Takahiro Akashi > Best regards > > Heinrich > > > > > > # Again, this method can also be applied even without my patch. > > > > -Takahiro Akashi > > > > > Will you provide the missing patch? > > > > > > Best regards > > > > > > Heinrich >